2023-03-24 TTA Requirements Meeting

• Date: //date
• Time: 9:00 ET
• Location: nraozoom04 
• Sprint Calendar

Attendance:

• Jeff Kern
• Dana Balser
• Mark Whitehead 
• Allison Costa
• Mark Ferguson 

Agenda:

• Supplemental Diagrams in Confluence now for reference:
  • https://open-confluence.nrao.edu/x/WwCtBg

• Is this actually automatic or does the TTA member initiate this? STT-904 - Getting issue details... STATUS
• Currently, we use the Review State of Finalized/Closed to prevent edits to ISRs STT-879 - Getting issue details... STATUS
  • (How) Do we prevent modification of ISRs with Review Type = None currently?
  • Suggestion: At initiation of Consensus sub-phase, all ISRs are immutable for the SRP member

• What do we mean by "Reviews" in the UI currently? (Allie)
  
  • Proposal Process
  • "Review Process" 

• Here is a link to some GBO DSS documentation to clarify the distinction between DSS and PHT.

Further discussion on STT-907 - Getting issue details... STATUS

• TTA member can modify ISRs (Review State, comments and score) up until Consensus starts for a panel
  • Note, this means they cannot Close an ISR once Consensus starts.
• TTA member can change Review Types until the NLR is generated
• TTA member can modify Consensus reviews (Review State, comments, score) up until Disposition Letters are sent.

Consequences of changing ISR Review States and Review Types

STT-1201 - Getting issue details... STATUS

STT-1200 - Getting issue details... STATUS

Recall:

• Finalizing ISRs is a per reviewer action. To Finalize, the ISRs with Review Type of Primary, Secondary, or Tertiary must be in Review States of Saved or Completed.
  • For ISRs with Review Types of P, S, or T and Review States of Saved or Completed, the Finalize action changes the Review State to Finalized. 
  • If the Review Type is None, the Review State does not change (Mark - currently review state is changed to saved/completed anytime an update is made).
    
  • If the Review State is Finalized or Closed, it does not change the ISR's state.
• Finalizing calculates the Normalized Individual Score (NIS) using all ISRs with a Review State of Finalized and a Review Type of P, S, or T. STT-1166 - Getting issue details... STATUS and  STT-879 - Getting issue details... STATUS .
  
  • ISRs with Review States of Finalized or Closed cannot be modified by SRP members.
• To start Consensus, all ISRs in a panel with Review Types of P,S, or T must have Review State of Finalized.

Use Case 1

A SRP member has Finalized their ISRs. It is prior to Consensus Reviews. One of their ISRs has

• a Review Type is None.
• a Review State of Blank, Saved, or Completed (only states allowed if in process).

1. If the TTA member changes nothing,
   1. the SRP member is (as of Sprint 50) able to continue editing their ISR and save edits into perpetuity.
   2. Even though the comments and score won't go to Consensus, it is best to have a hard stop to their edits at some point.
   3. Proposed Fix: Initiating Consensus should prevent edits by SRP members to any ISRs associated with that panel.
2. If a TTA member only changes the Review Type to P, S, or T,
   1. the SRP member can modify their review as needed. The Finalize button will trigger.
   2. The correct NIS's will propagate into Consensus and the TTA member cannot start Consensus until the SRP member finalizes (again). This is the outcome/system behavior we desire.
3. If the Review State is changed to Closed, then no further action is needed.
   1. This is the outcome/system behavior we desire because nothing actually change for Consensus.
4. If the TTA changes the Review State to Finalized
   1. The NIS does not include this Individual Score in its calculation. This may not be what the TTA member intended though!
   2. The ISR comments will go to the Consensus comments because the criteria is different than NIS calculation.

Use Case 2

A SRP member has Finalized their ISRs. It is prior to Consensus Reviews. One of their ISRs has

• a Review Type is None.
• a Review State of Closed.

1. If nothing changes,
   1. the SRP member cannot edit this ISR and it doesn't not go to Consensus.
2. If the Review Type changes to P, S, T
   1. the SRP member can edit Consensus Comments but yet their scores and comments would not affect consensus.
   2. This is perhaps a useful state in some ways but very out of process. TTA member beware.
   3. If it changes to Tertiary, SRP member cannot edit Consensus comments.
3. TTA member changes the Review State to Blank, Saved, or Completed
   1. the SRP can edit their ISRs but the changes do not go to Consensus or affect the NIS.
   2. Even though the comments and score won't go to Consensus, it is best to have a hard stop to their edits at some point.
4. TTA member changes Review State to Finalized,
   1. Individual Score is excluded from future calculations of the NIS which is perhaps not the intent!
   2. ISR comments will go to Consensus because the criteria is different as of Sprint 50.

Use case 3

A SRP member has Finalized their ISRs. It is prior to Consensus Reviews. One of their ISRs has

• a Review Type is Primary, Secondary, or Tertiary.
  
• a Review State of Finalized (only one allowed in process)
  

1. No changes made
   1. SRP member cannot edit their ISR and NIS has been calculated properly. ISR comments go to Consensus.
2. TTA member only changes the Review Type between P, S, and T,
   1. no changes occur that affect ISRs, the NIS, or the ISR comments.
   2. It only changes the ability to modify to Consensus Reviews.
   3. This is the outcome/system behavior we desire.
3. TTA member only changes the Review State to Blank/Saved/Completed
   
   1. Consensus cannot be initiated until the SRP member elects to Finalize their ISRs again. Note, it does not matter if the Review Type is changed between P, S, or T. 
   2. The correct NIS's will propagate into Consensus and the SRP member has to Finalize again.
      
4. TTA member only changes the Review Type to None:
   1. The previously calculated NIS does not reflect this change as there is currently not an automatic recalculation of the NIS.
   2. Furthermore, the Finalize button will never trigger for the SRP member, so there is no way for the SRP member to force the recalculation.
   3. ISR comments will go to Consensus because the criteria is different as of Sprint 50.
5. TTA member changes the Review Type to None and the Review State to Blank, Saved, or Completed:
   1. The previously calculated NIS does not reflect this change as there is currently not an automatic recalculation of the NIS.
      
   2. Furthermore, the Finalize button will never trigger for the SRP member, so there is no way for the SRP member to force the recalculation.
   3. ISR comments will not go to Consensus though.
      
6. If a TTA member changes the Review State to Closed,
   1. the Review Type is always forced to None.
   2. Further edits are prevented because of the Closed state
   3. The previously calculated NIS does not reflect this change as there is currently not an automatic recalculation of the NIS.
      
   4. Furthermore, the Finalize button will never trigger for the SRP member, so there is no way for the SRP member to force the recalculation.
   5. ISR comments will not go to Consensus though.

The TTA member could use the Finalize button for the SRP member, which would partially resolve the NIS being out of sync.

1. Recall that if the TTA member uses the Finalize button for an SRP member:
   1. all of their ISRs with Review Type of P,S, or T with review states of Blank → Closed
   2. ISRs with Review Types of P, S, T and states of Saved/Completed → Finalized
   3. ISRs with Review Types of None have no state change
      
   4. ISRs with Review States of Finalized and Closed have no state change
      
   5. Only ISRs with Review States of Finalized and Review Types of P, S, or T are used to calculate NIS.

However, the critertia in STT-1166 - Getting issue details... STATUS needs to be changed to handle the propagation of ISR comments into the Consensus.

In Consensus, an ISR review state, comments, and score cannot be modified by anyone, but a TTA member is able to modify the Review Type.  At the start of Consensus, the NIS per reviewer is copied into the FNIS.

• Edge case 1:
  • SRP member A for Panel 1 finalizes their ISRs. Their Consensus Meeting starts for Panel 1.
  • For a good reason, the TTA member changes one of SRP member A's ISR's Review Type to None, which previously had a Review Type = Secondary. 
  • This change means that SRP member A cannot enter or complete Consensus Comments for that proposal. This change cannot affect the NIS or FNIS or any other score or availability of ISR comments because all of those objects are defined at the start of Consensus.
• Edge case 2:
  • The SRP member A is subsequently assigned an external ISR after edge case 1 occurs. They do their external ISR and hit finalize.
    
    • The ISR with a Review State of Finalized and a Review Type of None will be excluded from the calculation of the new NIS. The new NIS will be discrepant from the NIS shown in Panel A but this is acceptable.
      

Summary:

• The TTA member should always have access to the bulk Finalize button, regardless of the triggering criteria, in order to "fix" the NIS if an out of process action is taken.
• A TTA member should avoid changing the individual Review State of an ISR to Finalized unless they REALLY understand the process. Finalizing should only be done via the bulk action to ensure the NIS is properly calculated.
• Changing the Review Type to None during Consensus will not change the NISs or ISR comments available to the Consensus panel.

Open Actions: