TTA Tools Sprint Feedback Page

TO TEST

DONE

• Generate a new Solicitation for PPR (QA Sprint 48 1) with 6 proposals. I get 6 notifications the proposals have been submitted.
• Do not close, so have to refresh the Reviews tab to see the configuration option.
• Able to make panels, vet, and assign proposals to panels manually.  Save all.
• Finalize buttons appears when proposals have been vetted and panels assigned to all available SCs. But it gives an error that says "Configuration could not be finalized" appears as a banner but if I look in the system log, then I see "A backend error occur at 'api/panel_configuration_complete/22': validation errors found when completing ScienceReviewPanel configuration on Solicitation: One or more Science ReviewPanels lack a chair (28,29,30) Solicitation is Open"
  • Ah, forgot to assign a chair. Okay. I assign a chair but the save button doesn't appear because the FE doesn't think anything has changed. So I have to work a little to make it think a change has occurred because the just changing a panel's SC to a different one and back doesn't do it. The FE thinks that's the "same". A different chair should really count.
    • As a TTA member, I would like changes to Chair Assignment to trigger the Save option in the panel.
  • Use finalize button. Still get an error that "Configuration could not be finalized" in the banner. Looking in the system messages, I see that it is because the Solicitation is open. Let me go check that it indeed did not finalize though.
    • As a TTA member, I would like the reason configuration could not be finalized to display as a banner.
  • The panels and their members are visible now in the Reviews page but there isn't anything to do because the configuration isn't finalized e.g., not conflicts can be declared, not assigns of Review Types can be viewed or done.
    
    • Does this auto happen on a save?
      • Make new solicitation QA Sprint 48 3 with 6 proposals. Do not close. Go to reviews page, refresh to see list.
        • As a user, I would like to not have to refresh a page to ensure I am seeing the correct content (story already exists though).
      • It happens when both vetting and panel creation is saved.
    • If I change a srp member does it propagate correctly?
      • Yes, it appears to propagate correctly.
    • This is a choice if we want to lock the view until Configuration is Finalized.
• If I do not change any SCs during vetting, such that all the Requested SCs are the same (GWT), and instead just distribute the proposals across the panels, the finalize button will not appear until I have at least 1 Vetted SCs per expected Solicitation SC.
  • I can change the Vetted SCs to match the expected and then only give 2 of the three panels proposals and the finalize button works. It looks like the criteria is that at least one proposal per SC is required to be finalized. I thought the requirement was
    • All proposals must be vetted
    • Each Science Category, as specified in the Solicitation, must be assigned to a panel.
    • The Solicitation is Closed.
    • As a product owner, I would like the criteria for Finalization to be clear and correct.
  • While trying to understand this SC assignment, 2 of 6 proposals just disappeared from the list. They happened to be the ones assigned to a panel that I changed the SC of and saved.
    • Replicated in Sprint 49. Any edit to a panel that has proposals assigned to it will "delete" those proposals from the UI permentantly.
      
• Finally Finalize QA Sprint 48 2. No error appears. List of Solicitations has a marker that says "finalized" now.
  • I can go into the configuration panel but changes are not saved. An error is thrown saying it cannot be saved.
    • The Configuration panel should be available to TTA member because that is where the vetting comments are stored (for now) and maybe the TTA member wants to double check assignments, though they cannot change them.
    • The save button should just be grayed out I think. Much like the Author copy isn't available on proposals after the close of solicitation. A banner display with "Cannot modify" would also be nice.
      • As a TTA member, I would an indicator that I can no longer make modifications to Vetting or Panels.
• Finally inside the Panel View of SRPs as a TTA member.
  • Copy URL and log in a chair for NGA. Paste URL so I can see the Chair's view of the matrix.
  • There's a state marker for Consensus as well as the ISRs states and review types.
  • This is very cluttered now.
• Chair Conflicts: Go to Chair's conflicts so I can certify as the chair.
  • Set both to available. Click Certify, which shows up but isn't available until I have set both from Unknown. After certify, I am on the ISR screen. Seems to work correctly.
    • Marker that I am certified.
    • Navigation button "back to panel".
    • Shows Review State (default None).
    • No Review Type, which isn't expected
    • Only clicking on the drop down arrow (very small) expands the proposal.
    • Have place for comments, have a place for score. Can see where proposal will go eventually.
    • Ordering of Reviewers has changed for some reason.
      • As a TTA member and SRP Chair, I would like the ordering of the reviewers to not change on the Panel View.
    • I cannot assign multi primaries or secondaries without a warning message. It does not require me to assign any primary or secondary role. I can save if all are None. I can save if all are Tertiary.
      
    • As a Chair, I cannot see the other reviewer's conflicts or ISRs from the panel but! I found later that I can just change the URL and then see them.
• SRP Reviewer: Log in as TTA member, navigate to srp member's conflicts. Copy URL, log in as the member. Paste URL. Can see their view now.SRP
  • Conflict management:
    • I can see Title, Proposal ID, Abstract
    • Setting to Conflicted will make a Reason text field appear. Give a reason.
  • Can Certify before a response is given in the text field but a str must be given or else an error is thrown.
  • After certify, I can see the ISRs.
  • Once certified, I cannot see the conflict management (good).
  • Conflict state not shown on proposal list.
  • I can enter in ISRs for the proposal for which I marked Conflicted. 
    • As a SRP Member, I should not be able to enter comments or a score for proposals for which I am Conflicted (+AutoConflict)
      
  • There is no back to panel option which is fine because this is the SRP reviewer's view and they don't get a panel view.
  • There are no filters/sorting on the list of Proposals when viewing ISRs
    • As a SRP Member, I would like filtering on the Proposal List by Review Type, Review State, Conflict State. (maybe this is overkill to have both)
    • As a SRP Member, I would like sorting on the Proposal List by Review Type, Review State, Proposal ID, Conflict State
• TTA Member:
  • I can see the Conflict Declarations of any reviewer at any time, so I have access to the reason.
  • I can change their conflict states and add a reason if needed. Certify again.
  • Change a state from Available to Conflicted.
    • On the panel view, it shows up correctly, but I know that reviewers can still see Conflicted Proposals so it isn't changing things downstream.
• Chair: Log in as chair.
  • If i paste the URL from the SRP member, I can see their ISRs.
    • As a product owner, I would like the Reviewers to not be able to access another reviewer's ISRs or conflict via pasting the URL.
  • Everyone has certified conflicts, I can see the marker that says they are certified now. I can see one member is conflicted. The marker is small though.
  • I can still give the conflicted reviewer a Review Type.
    • As a Chair, I would like to be prevented from assigning Review Types to a Conflicted ISR
  • I can save. No confirmation on a save
    • As a Chair, I would like confirmation of a successful save when saving Review Types in the Panel View.
  • As the chair, I go to do my ISRs. I can see the the Review Type in the ISRs that reflect the assignments I made.
  • I entered comments into a ISR but left the score as a default of 0. I tried to save. It rightly threw an error that I didn't have an acceptable score but it looks like it still saved. The Review State is showing Saved now.
    
    • As a SRP Member, I would like the list of Proposals to not reorder after I have modified by ISR.
      
  • It would be nice to have a message saying I will lose my work if I don't save.
    • As an SRP member, I would like a warning before I navigate away from unsaved work in Consensus and ISRs.
  • There isn't an option to Complete or Finalize my reviews.
  • I went back into reviews to move them to Saved at least and suddenly there were pregen Comments?
    • Saving doesn't clear the review changes pending. Maybe saved isn't hooked up yet.
  • Going to Consensus.
    • I can already navigate into Consensus but it is not connected so is just there for show.
    • Feasibility tab kicks me out of the review (doh).
    • On list of Proposals
      • Mean Finalized Normalized Individual Score
      • Std of ^
      • SRP Score
      • Title, Proposal ID
      • Who is Primary and Secondary
      • (Consensus) Review State
      • Missing Completed/Finalized options still
    • In expanded Proposal view:
      • SRP Score and place to modify if chair.
      • Comments for PI (not yet prefilled prompts)
      • Internal Comments (not yet pregen prompts)
      • In Reviews tab:
        • a "Score" which is presumably the Finalized Normalized Individual Score per ISR
          • The chair can change these
        • Comments per ISR
        • Missing - Normalized Individual Score
    • You can sort and filter on the list of proposals in Consensus. I don't think we need both; now that I look at it, I like sorting more than filtering here.

STT-863 - Getting issue details... STATUS

OSR proposal - Submitted

• I could save an edit to Author and Observatory Copy while Proposal State is In Review.
• Though it says it saved to the Observatory Copy, it actually applied them to the Author Copy instead.
• The changes did not show the changes in OSR UI in any Review State.

PPR does not show many details yet, but it looks like it doesn't work there either.

• I tested changing the Science Category on the Obs Copy and saving before the Solicitation closes and it did not affect the title I see in the Vetting phase.
• Change the Author Copy title and Science Category of a Submitted Proposal. Resubmit:
  • the title change is shown properly in the Vetted UI.
  • However, the Vetted Science Category shows up as the original Science category. The requested science category shows up as the one I changed it to in the Author Copy. The "unlinked" icon is shown already, though I haven't made any vetting changes.
• I changed the title of an In Review Obs Copy. The save was applied to the Author Copy only apparently. The change was not shown in the title in Vetting, though I could navigate into the proposal from vetting and see that it was applied to the Author Copy.

It seems like the "save" function is meaningless on the Obs Copy. Any changes I committed to a Submitted or In Review proposal applied instead to the Author Copy. Even as a TTA member, I could not resubmit the proposal to force the change (not that it would have worked anyway because no changes could be saved the Observatory Copy).

STT-861 - Getting issue details... STATUS

As author, I had a proposal for a solicitation +ppr that was open. I saved but did not submit it. Only author copy exists. I delete it. It is still on my list of proposals as an Author but I cannot edit it.

As a TTA member, I can see the Hidden proposal. I can get into it an edit it. I can save changes. I cannot submit it though, even though the CfP hasn't closed.

• I can withdrawl it though? I thought only Submitted proposals could be withdrawn.
• I now appears in my proposal list as the author and I cannot edit it when it is withdrawn.
• There is not an observatory copy though, so I cannot see anything about the proposal. This needs to be reconciled with withdrawn state model transitions.

There is another hidden proposal that is not withdrawn, just deleted. I close the solicitation.

• As a TTA member, there are not Observatory Copies to edit or view for either proposals because they were never submitted. I can view the Author Copies though.
• There is no submit button. I can make edits and save it, but I am never given a submit button.

At least neither the Withdrawn or Submitted ones show up on the Reviews Page but only because, I suspect, they were never submitted.

What is weird is when I navigate into a Proposal with Proposal State of Submitted, I can see a submit button. It isn't available but it at least shows up in the UI. It doesn't even show up in the UI for the case I was describing prior to this one.

I withdrew a Proposal after the Close and it still appears in the Vetting UI.

I do not understand the logic behind the ordering of the filtering in the Proposals List.

Dana (Firefox, Fedora)

--------------------------------- 
User: Dana Balser_TTA |
---------------------------------

First generate test solicitation.

Solicitations
-----------------

1. Click Generate Test Solicitation button.
2. Enter "sprint47Test" for name; enter "demo47" for proposal code
   prefix; enter "10" for proposal count; and select PPR.
3. Click Submit button.  Did not seem to take; needed to refresh
   browser.  I did receive 10 notification emails.

Proposals
--------------

I see the 10 proposals for this Solicitation.  Looks okay but they are
all in GWT which is odd.

Reviews
------------

Initially I do not see the generated Solicitation.  Need to refresh
browser.

1. Click Configure.
2. Enter "GWT" as name for new panel; click "New Science Review Panel" button.
3. Select GWT science category.
4. Add Amy (chair), Mark, Toney, Jeff, and Ryan as panel members.
5. Click Save button.
6. Check vetted buttons for all 10 proposals.
7. Select GWT SRP for all 10 proposals.
8. Click "Save Proposals" button.
9. Click Finalize button.  Got error message that "Configuration could
   not be finalized".  Refreshed browser.  Click Finalize button again
   with the same result.  Go to Proposals page and back.  Refresh browser
   to see Solicitation, and then click on bar.  Now I see the GWT panel.
   I did not receive a notification email.
10. Click on GWT panel.  I now see a summary view of panels (I think),
    as I have only configured one SRP.  But I cannot do anything.  I
    do not see the full matrix of reviewers vs proposals, just a
    summary at the top of the page.

Start over!

Solicitation: dsbTest47
Proposal prefix: dsbTest
Proposal count: 10

When configuring the panels I messed up since I created a PCO SRP,
connected to the PCO science category, but then realized the PCO
science category cannot be selected when vetting.  Anyhow, I tried
to save proposals but could not ever get finalize button.

Try again!

Solicitation: dsbTest47_2
Proposal prefix: dsbTest_2
Proposal count: 10

When configuring the panels I kind of maybe messed up again.  I did
not select the chairs until after I clicked Save.  Anyhow, after
vetting the proposals I clicked Save Proposals.  This time I was more
patient and waited until the Finalize button appeared.  Took more than
10 seconds.  Then clicked the Finalize button.  Get same error message.
Get same result.  No notification email.

Try one more time (next day)!

Solicitation: dsbTest47_3
Proposal prefix: dsbTest_3
Proposal count: 10

Same result.  I also saved the url:

https://tta-test.nrao.edu/reviews/solicitation/18/science-review-panel/19

and then logged in as the chair (Lorant Sjouwerman), cut/paste the url,
and get the same result.  Saved two screen shots: one of the configuration page
just before clicking the Finalize button, and one of the review assignment page.

After talking with Allie she had similar problems but recommended that
I close the Solicitation.  After this, and a few browser refreshes, I
was able to see the matrix.  Moreover, I received some notification emails
about the panel now being open for business.

-----------------------------
Lorant Sjouwerman |
------------------------------

Next start assigning reviewers to proposals.  

1. Assign reviewers to proposals.  Automatic conflicts not working but
   I think that was expected.  That is, I can assign someone who is conflicted
   as Primary.
2. Click Save.  Not yet implemented as expected.

Overall, I think this page is too busy.  Too much information to get
an overall view of the status.  Breaking each cell in the grid into
sub-cells (P,S,T,N), together with the conflict and review state, adds
a lot of information.  I think having text (review type) and color
(conflict/review state) is more compact and contains most of the
required information.

Including a summary of the conflict/review state and review type
assignments along the rows and columns, however, is very useful.  It
does add to the amount of information to the page but is worth it.

Next start the conflict declarations.

1. Click on my name.
2. View Instructions.  Nice.
3. Declare if I am available or conflicted.  For a lot of proposals it
   might get tedious clicking available for most of the proposals, but that
   might not be a bad thing.  Forces folks to decide.
4. Click "Certify Conflict Declaration".  Not yet implemented.

--------------------------------- 
User: Dana Balser_TTA |
---------------------------------

Next login as a TTA Group member and override a conflict assignment.

1. Click Lorant Sjouwerman.
2. I can override a conflict status.  Not sure how to save.  I do not
   receive a notification email; I recall Sam was able to get a
   notification in the sprint review.

As a TTA Group member I can also see the Individual Science Review
structure.  Overall this structure looks good to me.

Dana (Firefox, Fedora)

--------------------------------- 
User: Dana Balser_TTA |
---------------------------------

Solicitations
-----------------

Attempt to generate test Solicitation with proposals.

1. Click "Generate Test Solicitation" button.  Form appears.
2. Enter Solicitation Name (Sprint 46 Testing), Proposal Code Prefix
   (S46Test), Proposal Count (10); select PPR Proposal Process; click
   submit.  I see the new Solicitation.  Good.

Proposals
--------------

Check that the test proposals exist and are reasonable.

1. Filter on "Sprint 46 Testing".  I can there are 10 proposals.  They
   have the correct proposal id prefix.  They are all submitted and
   have the same science category (GWT).  Probably want some variation
   here in the science category.

Reviews
------------

Perform vetting of the science categories.

1. Initially I do not see the Solicitation I created, but then
   remembered I have to do a refresh.  Now I see "Sprint 46 Testing".
2. Click Configure.  I can see the interface.  Proposals (left) and
   Panels (right).  Little confused at first.  Not sure what
   "assigned" means under Proposals section.  The Panels section must
   be to create SRPs and to connect them to science categories.
3. Let's create SRPs first.  Enter GWT, click New Science Review Panel
   button.  Continue for SFM and NGA.  The number next to Panels is 2
   but I have created 3 SRPs.  This number does not change.
4. Select the obvious science category to the SRP.  I see that more
   than one science category can be connected to the SRP (okay).
   Across from Panels I see 0/3 Science Categories; expected this to
   update.
5. Add reviewers.  As you start to enter a name the interface shows
   possible options which can be selected (okay).  Once selected a new
   search is opened with the previous name.  Probably better if this
   was blank.  Select chairs by clicking icon (okay).  Only one chair
   can be selected but the requirement is to have one or more chairs.
6. Refreshed the browser and this cleared everything.  Oops.
7. Start over.  Redo 3-5.  Appears that actions in the Panel section
   are not changing anything in the Proposals section.
8. Move to Proposals and start vetting.  Seems straight forward, but
   again the numbers at the top (0 vetted 0 assigned) are not
   updating.  The panel selector in the top right of each proposal is
   none and grayed out.  I was expecting this to be updated once I
   connected the SRP to the science category.
9. Filter on Science Category.  When I select GWT the form clears.
   All science categories go back to GWT and none are vetted (checkbox
   cleared).  The filters do not appear to be working.  I am assuming
   what is meant by assigned is when a science category is connected to
   and SRP.  

I can potentially see the value of having the functionality of
assigning SRPs to science categories and the vetting of science
categories to be on the same page.  But hard to tell since the
interface did not appear to be updating in some places.  Actions on
the Panels section had no effect on the Proposals section.
Regardless, I do not think we will be doing these at the same time (or
even the same TTA Group member).  So I would keep them separate.

Is the search on science category the requested or vetted?  Seems like
it would be useful to have both.  Or maybe just the vetted (which
initially defaults to the requested).

Ah, just realized that under Panels I had to click the Save button.
When I do this I see 3/3 Science Categories (got updated). Still 2
next to Panels.  Too, no changes to the Proposals section, except that
I can now select the Panel (no longer grayed out).  I would have
thought this would automatically update since I have already connected
each panel to a science category.

And when I click Save Proposals under Proposal I see 10 vetted now.
Next, for each proposal I select the panel.  If I click Save Proposals
again the number updates: 10 Assigned.  Okay good.  As noted, this
really does not make sense because I have already connected the panel
with the science category under Panels.  So for proposal S46Test-001,
which has a vetted science category of Gavitational Waves and
Energetic Transients, I can select the SFM panel.  But under Panels
the SFM panel is connected to Star Formation.

After saving things I see that the filters seem to work.  Okay, I
guess this makes sense.  But if I do not want to loose work I have to
keep clicking save.

---------------------------------

Allie Costa

---------------------------------

Solicitations

• Can generate a demo solicitations and proposals easily enough.
• When I hit the save button though, it leaves the information in the UI that I just asked to be generated. There isn't feedback to show that the solicitation is actually generated.
• It would be nice if in the list of solicitations, the text were aligned within the list.

PPR Review

• The landing page for the Review Tab shows a nice summary of each of the solicitations+proposal process.
• I can only access the review configuration page for a Solicitation that is closed. This is not the desired behavior. We want to be able to configure the panels before the solicitation closes. The vetting will only occur after the close really. I think this is more evidence that the vetting and panel configuration can indeed be separated.
• Clicking anywhere on the line for a panel, takes me to an overview of the panel (if there are people are assigned to it). That's neat.
• There's no "easy" way to back out of panel view without clicking on the Reviews Tab, which takes me back to the landing page.
• (Bug) You have to refresh the page when entering the Review Configuration UI, otherwise the proposals are populated and the review panels are not displayed when added.
• The Finalize Button is briefly displayed when I first enter the page, even when it should not be. It triggers when all proposals are vetted, all science categories are assigned to a panel, and all proposals are assigned to a panel. I think this is okay. Maybe it would be better if it was always there but grey'd out when not viable? Like the submit button on proposals so the user knows there's another step.
• There does not seem to yet be a way to auto distribute proposals to panels.
• Proposal Vetting
  • Can navigate into the proposal pretty easily from the vetting side.
  • Can change the Science Category and enter in comments.
  • Note! The save button on the vetting side is independent of the same button on the panel side. So if there are unsaved changed on one or the other, it won't save them. This isn't clear in the UI that is will happen though. It is nice seeing the proposal information next to the panels but really I think these could be separate tabs. Since most cases we will NOT be assigning by hand, it isn't that important to have both views at once.
  • After save, order of list changes, which is confusing at first (known already).
• Panel Creation
  • Note! The save button on the vetting side is independent of the same button on the panel side. So if there are unsaved changed on one or the other, it won't save them. This isn't clear in the UI and maybe suggests that these really should be separate tabs for clarity.
  • We still want a more reviewer focused view. As we add more people and have to search for them, we want to be sure that the reviewer we are adding is the correct one or that they indeed have a user account.
  • How do I delete a panel or rename it?
  • I tried to have identical names for panels and it correctly gave me an error. But now I can't delete or rename it without hitting refresh.
  • The number next to Panels is (2) but the number next to Proposals is (5). If these are showing how many of each, then Panels was showing (2) when I only had 1 panel created and never updated when I eventually made 3 panels.
  • I do think the drop down on the panel creation side should be restricted to the SC in the solicitation.
  • How do you see the proposals that are assigned to the panel in the panel side? Maybe it isn't supposed to show them there and you use the proposal vetting side to inspect that. I am still concerned about the save relationship between the left and right sides of the screen then.
• Refresh Bug Again: I created two solicitations with different names.
  • I configured the review for one of them and saved.
  • I configured the review for the other one and saved.
  • I went back to the first to look at it and it had all of the panels from the other one in addition to the ones that were supposed to be there (see image). The proposals are not shared though.
  • I can modify all of them. Saving throws the error about duplicate names.
  • I cannot delete panels however.
  • If I refresh, then it populates the panels properly.

Dana (Firefox, Fedora)

--------------------------------- 
User: Dana Balser_TTA |
---------------------------------

Solicitations
-----------------

Inspect the Solicitation created by Sam during the sprint review using curl and
the ability to Close Solicitations.

1. Click on "Sprint 45 Demo."  Looks okay.
2. Click Close button on Solicitation "Sem_25A".  I now see this is indicated as closed.
3. Go to Home page.  I now see that this Solicitation is listed under Recently Closed Solicitations.
4. Go to Proposals.  Under the list view there is no indication that Sem_25A is closed.  It might
   be useful to indicate this Solicitation is closed.
5. Click Add.  When I try to select a Solicitation I notice that Sem_25A is not listed.  Good.

Proposals
--------------

Inspected the Demo Proposals.  We probably should have dummy authors
since we do not want to confuse our users or TTA Group members.  Might
not want to use a Beasley memo for the scientific justification.  In
some cases we will need (I think) to include a viable Allocation
Request.

Reviews
-----------

Inspect SRP UI prototype which is under construction.

1. Click SEM_25A under mocks.  Need to click twice as indicated at the sprint review.
2. Click on Science Panel 54.
3. Matrix view is okay.  Might be better to list reviewer across the
   top (columns) and have the proposals in the left (rows).  But seems
   reasonable otherwise.
4. Enter some conflicts.  Not connected to a given user yet but this
   was expected.  The Certify Conflict Declarations button will highlight
   once they are all entered.  

Dana (Firefox, Fedora)

--------------------------- 
User: Dana Balser |
---------------------------

Proposals
---------------

Create a proposal and check if you can add and view the science category.

1. Click Add.
2. Enter title.
3. Select Solicitation (Sem_25A).  After selected there is an option to select the science category.
4. Click Create.  Error message and below the science category there is red text "Select a Science Category".
5. Select Science Category (Star Formation).
6. Click Create.  We discussed this at the Sprint Review but it is not clear what fields should be
   created at this stage.  We probably need some unique identifier for the proposal at this stage since
   in practice the title could be duplicated.  So maybe the solicitation is the only field necessary. But
   it seems that science category should not be listed at this stage but later.  
7. Enter abstract and save.
8. Click List.  I can view the science category.  Looks good.  No filtering option yet.
9. Create another proposal and select a different science category.  Looks okay.
10. In Basic Information, select and difference science category, save, and check.  Looks okay.

--------------------------------- 
User: Dana Balser_TTA |
---------------------------------

Reviews
------------

Check that a TTA Group member can perform the vetting of science categories.

1. Click on Configure for SC_GBT_24B Solicitation.
2. Click on Vetting tab.  The vetting and review configuration operations are on the same page.
   Maybe better to have this separate but I could be convinced otherwise.
3. Click binocular icon.  Opens new browser tab to the Proposal List with error message
   "Proposal 'SEM25A-001' cannot be viewed".  Maybe this is not yet implemented.  Best to
   just open a PDF of the proposal.
4. Click > icon for SC_GBT_24A-1 to expand.
5. Select PCO and add text to Notes.
6. Click Vetted check box.
7. Click Save Vetting Info button.  Not sure this does anything.
7. Went to Proposal tab to check something and then back to Review-->Vetting.  Changes do not
   persist but I recall that is expected at this stage.
8. Vetted a few more proposals.  Looks okay.
9. Click Vet All Proposals button.  The remaining proposals Vetted check box were checked.

Overall this looks reasonable.  In the slim view I notice that the
science category is the vetted category which is good.  There is also
an icon next to the science category that indicates if the vetted
science category is different than the requested science category.  If
you make a change and then go back to the original the icon is not
updated.

We probably want to be able to filter on the science category
(requested and vetted).

Allie (Firefox,redhat)

Proposal Creation

• I do not like that the Science Category is part of the landing page for a new proposal. I think it should be on the next screen instead only.
• I can select a SC and it persists.
• I made a proposal and submitted it. The Proposal State updated to "submitted" but all of the information in the proposal is now shown until I refresh.
• Issues from previous proposal creation (e.g., sprint 42, 41) persist
• The Withdraw button is only available to TTA members. It is also only available if I am  editing a proposal. This button should be at a higher level that the edit view.

Reviews

• Review a newly created DDT proposal
  • Sam said that the backend wants the boolean for the score but the front end is not changed, so it can accept any number.
  • The Review State correctly changed from "blank" to "saved" when I save the OSR. It then goes to Finalized once I submit the review and I can no longer make edits to the review.
  • It is not obvious how to back out of this page though. Really I have to hit one of the top navigational tabs. There should be an "x" or close button.
  • I wish the acknowledgement bar (NRAO, AUI, etc) were lower because the proposal preview is very squished.
  • The Edit button should not be there (Sprint 43 comment)
• Review Configuration
  • I like the vetting page, but I do not have experience vetting proposals to know if this checks all the boxes.
  • New panel configuration page but it isn't complete.
  • Not sure of the interaction of how vetting will work and the panels, considering that a change to the vetted SC will affect where the proposal goes. Much of the panel configuration is still very much so under development, so likely this will become more clear later.

Allie (Firefox,redhat)

Review Configuration

• Cannot assign two chair to a panel, which is a requirement.
• want to consider UI for the 90% useage – automatic assignment of proposals to panels.
  • tta member is mainly focused on reviewers
  • information about the people (verify that it is the person we think it is)
  • separate feasibility from panel entirely.
    • feasibility review concept isn't correct
• protect again reviewers being on multiple panels
• adding an external reviewer to an ISR would be a separate interface because it happens after review configuration is finished
• OSR have review state (blank, saved, completed/finalized)

Dana (Firefox, Fedora)

Observatory Site Review

--------------------------- 
User: Dana Balser |
---------------------------

Proposals
--------------

Created a proposal

1. Click Add, enter title, select Solicitation SC_GBT_24B), save.
2. Enter General info, save.
3. Upload scientific justification.
4. Enter Capability Request, save.
5. Check Observation Specification (looks good).
6. Submit.  Acts like a DDT as the proposal state goes to "In Review".
   Proposal ID is SEM24B-005 (but okay probably not implemented yet).

Reviews
------------

I am able to see SEM24B-005 but no other reviews.  A bit odd.  Only
the TTA Group member should see proposals for review in the OSR.

---------------------------------- 
User: Dana Balser_TTA |
---------------------------------

Reviews
-----------

When I enter the Reviews tab I can see the proposals that are in the
"In Review" state.

Perform a review

1. Click on the Review button for SEM24B-005.  Layout is okay.  I can
   see details about the proposal below but no proposal ID.  Might be
   nice to have some info at the top of the page: proposal ID, PI, and
   title.  The most important info to see here is the technical justification,
   which does not exist yet.
2. Wanted to cancel but could not find a cancel button or icon; clicking
   the Review tab did work, however, and also gave me a popup message.

3. Entered a score (1), clicked save.  Status when from blank to saved.
4. Added some science comments for PI.
5. Added some technical comments for PI and internal.
6. Clicked Save button.
7. Clicked Submit Review button.  Review is finalized.
8. The review persists; I can leave page and come back.

Science Panel Review Process Configuration

--------------------------------- 
User: Dana Balser_TTA |
---------------------------------

Reviews
-----------

Under Mocks, clicked the Configure button for Solicitation Sem_25A.
First impression is that the interface is a bit confusing.  For
example, separation of science and feasibility reviews is not at first
clear.  After staring at this for a while I see the logic.  The panel
on the left show the items that are to be selected: science
categories, proposals, and review groups.  The panel on the right
makes the connections.

Tried to configure panels:

1. Added a panel: enter "SSP" and clicked "New Science Review Panel".
2. Selected science category "SSP" and two proposals: Sem_25A-1 and Sem_25A-2.
3. Selected Amy Mioduszewski (chair), Mark Claussen, and Emmanuel
   Momjian.  Odd that the name persists in the search box after selected.
4. Clicked Save button.  I now see the Finalize button.
5. Perform 1-4 to add SFM and PCO.  I was able to add the same person
   to two SRPs which I do not think is allowed.   But we do need a way
   to assign a reviewer in panel 1 to a proposal in panel 2.

Tried to configure feasibility reviewers:

1. Add Review Group: enter "HSA" and click "New Review Group".
2. Remove John Doe.  This does not work, but there is a note that this
   is only partially implement so okay.
3. Add Mark Claussen.  Again this does not work, but okay.
4. Perform assignment: select proposals to HSA group: Sem_25A-1,
   Sem_25A-2, Sem_25A-6.  I do not think this is what we want, however,
   since we changed the requirements to add users to proposals not
   groups.  The groups would act as an alias.

I would prefer we separate these configurations. For example, have a
tab that configures the science reviews and another tab that
configures feasibility reviews (which may be further divided into
technical and data management).

Moreover, I think the focus should be on people.  We are assigning
people to do things.  So for the science review configuration I would
have a list of the panels with the members listed below.  Something like:

SSP SRP        SSP Science Category v       Proposals v
==================================================================
Name                 Username              Email                                            Role
--------------------- ------------------------  -----------------------------------------   -------------
Lynn Mathews    lynndmatthews    lmatthew@haystack.mit.edu   chair
Paula Benaglia   pbenaglia              pben.radio@gmail.com            member
Jose Guirado      guirado                  jose.c.guirado@uv.es               member
etc.

PCO SRP        PCO Science Category v       Proposals v
==================================================================
Name               Username                Email                                          Role
------------------- --------------------------- ----------------------------------------- ------
etc.

The 90% use case will have one science category per SRP and the
proposals can be automatically assigned.  In practice I suspect we
will almost always want to upload a file.  The username is useful to
trouble shoot on the test server and the email helps to make sure we
have the right person (we have lots of duplicate accounts and I do not
think the new account system will "fix" this issue).

I am less sure about the feasibility review configuration.  Here
people are directly connected to proposals (not groups).  Need to
think more about this.

• DDT proposal created as Allie_Costa
  • hitting save does not kick the view over to Observation Specifications and the little icon on OS doesn't update until I go there myself.
  • when I hit submit, it leaves me on the author copy even though I should be in the Observatory Copy view only mode. I have to go back to proposal list to get to the Observatory Copy.
  • PID assigned, and datetime in the correct timezone available in the UI.
  • going to list of proposals shows the DDT is now "In Review", only observatory copy is available.
    • cannot see the Author Copy anymore and a nice tooltip shows that I cannot go to it either.
    • Still can't see the OSs
  • from a general user's POV, I'm done.
• Sem_25A proposal created without issue, submitted as Allie_Costa
  • Proposal view correctly shows the Submitted Proposal with a View and Edit button
  • View takes me to Observatory copy, where I can toggle directly to the Author copy and edit it there
  • Observatory copy does not have an edit option for me
  • when I am in the author copy edit mode, i cannot access the observatory copy.
• I can access the reviews page as a non tta member. I can't review a DDT or configure a panel though
• Logging in as TTA Allie
  • I can see all the proposals
  • I can edit observatory or author copy of proposal 1.
  • I can access the Reviews tab
    • The SC_GBT_24B has a configure panel. As a DDT, I'm not sure that is what we would want.
    • Currently the list of proposals will expand and it pushes the configuration panel down. This might be annoying when we have 300 proposals.
  • Reviewing a DDT
    • The panels are very squashed together when the review tab opens. I have to scroll to see most of the proposal information even though there is plenty of real-estate on the page.
    • The Observatory Copy is only shown in the review page but it has an edit button that redirects to the proposal list with an error message that says 'cannot edited this version" which is good that it doesn't allow me to edit but there shouldn't be an edit button there to start with.
    • I cannot see the Observation Specifications still.
    • I can navigate between the comment tabs without saving. yay.
    • The score should be a boolean or 0/1 for a DDT not a higher integer or otherwise.
    • Saved and submitted review for Proposal 1.
  • Reviewing Proposal 2 now.
    • Without any edits, the banner of Review Changes Pending is showing up.
    • Submitting the review changes the review state to Finalized.
    • Who did the review is not displayed anywhere that I can tell. STT-925 was that is was stored, not displayed I suppose
    • It is not clear in the review list what DDT proposal have a finalized review. Don't have a story for this yet.
    • No prompt for finalizing?
• Configuring a review panel
  • Saving a review panel didn't actually save it. Maybe for the better right now because we're experimenting with it.
  • I saved and then made someone a chair. It did not show the save button again.
  • Finalize doesn't do anything yet, as expected as we haven't done this story STT-899
  • I can add science categories to a panel
  • I can add proposals to a panel manually. fine until we get a lot of them ( upcoming work in STT-1078)
  • I can add science reviewers
    • adding via the search function is great but it also pre populates the same name into the search bar when i go to add another one.
  • I like the little icons on the side to track how many science categories, proposals, and chairs there are in a panel.
  • I like the tracking on the panel on the left which shows which proposals have been assigned. It would be nice to filter on that once we get a lot of proposals.
• Ignoring the feasibility reviews, as they are a place holder

Allie (Firefox, redhat)

User: Allie Costa

video of bug walkthrough

Proposal - VLA Continuum SEM_25A

• I created a new proposal, entered the title and hit save. Then I could enter the remaining basic information.
  • I cannot interact with the observatory copy, as expected.
  • With just the basic information provided, I tried to hit the submit button and an error displayed saying that it was missing the SJ, AR, CR, etc.
  • Now though, the "Proposal Changes Pending" banner will not disappear even when I hit save. Nothing has changed though from when I last saved it and when I try to navigate away, it brings up the warning that I will lose unsaved changes. Going to a different tab (SJ) clears it though.
• I can submit my proposal and the proposal ID assigned to it, the proposal state changes to submitted, and the time of submission is displayed. It is displayed in MST though?
• Now I should be able access the Observatory Copy but I cannot click on it. I have to go back to the list of proposals and only when I use the "view" button, can I go to the observatory copy. I can access the author copy from there. I suppose it makes sense because I cannot edit the Observatory Copy and I am in the edit mode for the author copy. This is not intuitive though for a proposer. On a submission, it needs to redirect to the observatory copy/view mode.
• Why does the banner say "Author Version" instead of "Author Copy"?
• There is a noticeable lag when navigating.
• In the observatory copy, It does not display information about the capability request(s). It says there are no observation specifications either, even though there are.
  • when I revisit it, now I can see the CR? Not sure why it didn't trigger it the first time. I can replicate this. I have to go to the Author copy first, and then the ARs will show up but then I lose the OSs.
• In the view only mode of the author copy (not what we initially discussed for the author copy but might be okay)
  • I recall that the display of these fields hasn't been addressed yet. All the information appears to the be there except the Calibration Parameters are missing (VLA) and the Advanced tab is missing (not that we necessarily need in it in the view only mode).
  • The observation specification for the AR looks okay and matches my expectations mostly.
• I like that the view only modes are summary-like.
• I tried to add another AR to my submitted proposal. I cannot save it because the save button is gone, so I cannot resubmit it.
  
  • Why isn't the save button appearing when I add a new AR or field source?
  • It only seems to appear when I edit a previously submitted field. I still cannot resubmit though, even though I have a whole new AR that wasn't submitted.
  • When I go to view the Observatory copy, it correctly does not show the new AR and the author copy does show it.
  • I had to back out of the proposal completely and then go back into it to be able to re-submit the proposal.
  • I could edit the existing fields, save, but again, the resubmit button is not available.
  • Deleting a FS or AR doesn't always work either

Proposal - GBT Special call

• I created a new proposal under a different solicitation and it pre-populated everything from the VLA continuum proposal until I hit refresh.
• 2 ARs, 1 CR each --> 4 OSs, one with all calibration parameters
• When I submit, it goes directly to In Review as expected.
• For the CR that has no calibration parameter specified, the tab is emtpy. For the one with the CP, then it lists them.

General

• When unsubmitted changes are pending between the author copy and observatory copy, the list view of the proposals correctly displays the banner. However there isn't any indication in the view only modes or edit mode that there are unsubmitted changes. This needs to be clearer to a proposer.
• I can delete a proposal in the draft state but it still shows up in my proposal list. the state is correctly "Hidden" at least.
  • I can edit it even though it is hidden.
• When I go in and edit a submitted proposal Observatory Copy as a TTA member, it immediately shows a banner saying "allocation request changes pending" even though I haven't done anything yet.
  • There is a save button at the Allocation Request level. Not sure what it does. Why I click it, it gives an error saying "check form for errors"
    • I can edit the CR and it has a different save button that is the normal one. It works as expected.
  • on the list of proposals, it does not show that there is a difference between the observatory copy and the author copy, which I think is okay.
• As a TTA member, the toggle between author and observatory copy in the edit mode works just fine.
• As a TTA member, I have to go into the edit mode to access the withdraw button. I think it would be available on the view modes too.
• If a proposal is withdrawn, the author should not be able to see the author copy, let alone edit it.
• Things are starting to feel "off" - likely because we haven't discussed optimizing really. For example, the list view of the proposals has different looks per proposal depending on the state. it just looks a bit weird, particularly for the tta member view that can see all the proposals. the lack of consistency is off putting to me.

Dana (Firefox, Fedora)

--------------------------- 
User: Dana Balser |
--------------------------

Proposals
--------------

- Create a proposal.  Throughout the process I can see in the top
  right the version: author (orange highlight), observatory (gray).
  If I click "observatory" nothing happens.  I can also see orange
  horizontal bar labeled "AUTHOR VERSION".

1. Click Add button.
2. Enter title, select solicitation (Sem_25A), and save.  
3. Basic Information tab: enter abstract and save.
4. Allocation Requests tab: click Add button, create Capability, and save.
5. Confirmed that an Observation Specification is created.

- Submit proposal.

1. Click Submit button.  I can see in the top left that the proposal is
   now submitted and a proposal ID.  In the top right the I now see the
   date of submission and a grayed out Re-Submit button.
2. Click Observatory button.  Nothing happens.
3. Click List button.  I can see the one proposal listed with
   submitted displayed (twice) and the proposal ID.
4. Click View button.  I now see the observatory version. Purple banner with
   label "OBSERVATORY VERSION".  The tabs to toggle between the
   Capability Request and the Observation Specification are missing.
5. Click Author button.  I can now see the author version with an edit
   button to the far right.  Here I do see tabs to toggle between
   Capability Request and Observation Specification.  Later I did this for
   a proposal that was in the draft state and as expected I only saw the
   Author version.
6. Click List button.
7. Click Edit button.  Now I see the Author version.  Observatory
   version is not active.  I guess this makes sense since I cannot modify
   the Observatory version.

- Re-Submit a proposal.

1. Click Edit button (in list view).
2. Edit abstract and save.
3. I now see the Re-Submit button is not grayed out.
4. Click List button.  I can now see "Unsubmitted Changes Pending".
5. Click Edit button.
6. Click Re-Submit button.  Re-Submit button is now grayed out again.
7. Click List button.   Comment about "Unsubmitted Changes Pending" is gone.

- Filters.  Create three proposals for different solicitations and in
  different states.  Tried several different combinations of filters
  for state and solicitation.  Seemed to work fine.

--------------------------------- 
User: Dana Balser_TTA |
---------------------------------

Proposals
--------------

- Withdraw Proposal.

1. Click Proposals.
2. Click Edit Button.
3. Click Withdraw Button.  I now see the state is withdrawn.  I can
   still edit this proposal which is correct for TTA group member.
4. Click Edit Button.
5. Edit abstract.  I can do this since I am a TTA Group member.  This
   is only reflected in the Author copy and not the Observatory copy.  I
   guess this makes sense.  I do not think the TTA Group member would
   really ever need to edit a withdrawn proposal but that is in the
   requirements.

---------------------------- 
User: Dana Balser |
---------------------------

Proposals
---------------

- Withdrawn Proposal.  I can now see that the proposal above has been
  withdrawn.  No Edit button which makes sense.

- List View.  It would be helpful to align the different fields that
  are listed: ID/State; Title/Solicitation; Submitted; PI; View/Edit
  Buttons (see image).

- Draft ID.  We need some proposal ID for Draft proposals just so we
  can reference the proposal when problems arise (e.g., helpdesk
  ticket during an open Solicitation---maybe out of scope here).

Dana (Firefox, Fedora)

-------------------
Dana Balser |
-------------------

Proposals
--------------

- I created a new proposal and filled in the Basic Information and created one Allocation Request.  I specifically did not import a Scientific Justification.  While viewing the Observation Specification I clicked the Submit button.  I got an error (validation).  I then imported a scientific justification PDF and while on the Scientific Justification page clicked the Submit button.  Seemed to work.  I can see the following at the top of the page.  Date appears to be the correct UT.

"SEM25A-004 Test submit 1 ..........................."
"Sem_25A 11/28/22, 3:18 PM Submitted"

- I changed the abstract and then clicked the Save button.  This took a few seconds to save but seemed to work.  I then clicked the resbumit button.  Seemed to work.  I can see the following at the top of the page.  Date appears to have been updated and the proposal ID is the same.

"SEM25A-004 Test submit 1 ..........................."
"Sem_25A 11/28/22, 3:26 PM Submitted"

- I changed the Calibration Parameters for the VLA Capability and then clicked the Save button.  After this I clicked the Resubmit button and this seemed to work.

- I am able to resubmit even if there have been no changes to the proposal.  I thought we agreed to gray out the resubmit button until there were changes but maybe this was not included for Sprint 41.

Allie(Firefox, linux)

Specifically testing Submission/Resubmission

• proposal already exists (QA sprint 40 proposal 2 ddt)
• Submitted from the Observation Specification tab.. On submit, the observations specification disappeared and instead the message of ``No Observation Specifications..'' is displayed. going to Capability Request and back to OS fixes this. Or a refresh fixes this.
• Proposal State changed to submitted and a date and time is displayed now. It displays UTC until a refresh, when it changes to local time. (Known)
• Changed the abstract, saved, and resubmitted. I believe that it worked because the date time changed. A warning popped up warning no history is kept - good.
• On proposals' tab, I see the state change and the updated datetime. I can filter on state.
• Changing the basic information, no save, resubmit → change not persisted. (Known)
• Changing capability request, no save, can resubmit → change not persisted. I would not be able to make a change to CR, and submit with an invalid OS because it would, presumably submit the one before from before the unsaved changes. It would be annoying for a user though to make all of the changes and then have them blown away on a resubmit because they did not save.
• Resubmitting on the CR editor briefly displays the Changes Pending banner and then reverts. I did not make any changes though beyond just resubmitted.
• There's no system message confirming the resubmission. (Add story)
• No validation still - I submitted an empty CR (not implemented)
• We apparently did not write the story to put the proposal ID into the UI. (Add story)
• I thought that the Resubmit button is available only if the Author Copy is out of sync with the Observatory Copy. A Save is required to make that check, I believe. The resubmit button seems to always be available, as long as the solicitation is open. (Add Story?)

Thoughts on save/resubmit

• Use case 1
  • I have a valid and submitted proposal. I change a CR detail. I would only like to submit a valid OS, so one must be generated.
    • Currently, the only way to generate an OS is with the save button.
    • If a Resubmit and Save happens together with the Resubmit button, then I would not have the chance to review the OS before submission. If I made a change that invalidated the OS, then the resubmit would throw back an error saying that validation failed but maybe it is a valid OS that asks for 100 hours when really I only need 1 hr because e.g., I flubbed the units on the RMS!
  • Opinion - the save must be separate from the resubmit and the resubmit should be visible but grayed out until a save is made.
• Use case 2
  • I have a valid and submitted proposal. I make a change to the CR, do not save, and go to the Basic Information to change the title. I am greeted with a pop up window stating I will lose my changes to the CR if I go away. I now know I need to Save the CR - thus generating a new OS (or getting an error message ). I have the chance to review the contents of the OSs.
  • Now when I go to the Basic Information and make a change, Saving before a Resubmit is an extra step. The OS contents are known to me (in theory) so I cannot mistakenly be asking for way too much time.
• Opinion - the resubmit or submit button should only be available on the Basic Information, Science Justification, and Observation Specifications editors. It should not be available on the Capability Request editor. Or, it should be moved higher than all of those and system messages could indicate that a submission or resubmit is available.

Dana (Firefox, Fedora)

User: Dana Balser

Proposals
---------------

- Create Proposal.  I had problems creating a proposal.  Basically I
  was tying to create several proposals quickly (without much detail)
  to fill in the summary list of proposals.  Here is the procedure:

  1. Click Add button under Proposals.
  2. Enter Title.
  3. Select Solicitation.
  4. Click Save (so far so good).
  5. Click Proposals (go to summary list).
  6. Click Add button under Proposals (create another proposal).
  7. I see the form to create a new proposal (title/solicitation) but
  the previous proposal is listed; that is, the form is not cleared.
  The system hangs (get the spinning cursor).
  8. Need to click Home to get out.

- Filtering.  This does not work as expected on the summary list view.

  State Filter: I can filter on All, Draft or Submitted okay but not
  the other fields (e.g., Withdrawn).  Maybe the other fields are not
  yet supported.

  Solicitation Filter:  At first this appears not to work at all but maybe
  the internet is slow to respond.  Selecting "20D" does not work, but maybe
  because this solicitation is not included.  

  Combination Filter: Sometimes combinations do not work.  For
  example, selecting State="Submitted" and Solicitation="SC_GBT_24B"
  list a submitted proposal (good) that is for the Sem_25A
  solicitation (not good).  See attached screen shot.

Proposals-->Allocation Requests
---------------------------------------------

- Navigation.  I created two Allocation Requests (ARs), each with one
  Capability Request (CR).  I saved them generating Observations
  Specifications (OSs).  I wanted to compare the OS for each AR.  To
  do this is a bit of work (see below).  This is very logical but time
  consuming.  Will folks want to compare OSs between ARs?  I did only
  because I wanted to compare the integration times that were
  calculated.

  1. Click List button under AR.
  2. Click AR1.
  3. Click OS.  
  4. To see the OS for AR2 I have to:
     a. Click List button under AR.
     b. Click AR2.
     c. Click OS.

Proposals-->Allocation Requests-->Capability Request
---------------------------------------------------------------------------

- Ordering.  Normally the ordering of the CR is: Field Sources,
  Spectral Specifications, Performance Parameters, Calibration
  Parameters, Advanced.  I performed the following operation:

  1. Deleted one source in Field Sources.
  2. Click Home (leave Proposals).
  3. Dialog box asking if I want to leave: yes (should not save edits).
  4. Click Proposals.
  5. Click Proposal in question.
  6. Click AR in question.
  7. Click CR in question.  I now see that the ordering of the CR
  is: Spectral Specifications, Performance Parameters, Calibration
  Parameters, Field Sources, Advanced.  (See attached screen shot.)

- Deleting. If I create a single field source (single spectral spec) I
  cannot delete it.  I have to create another field source (spectral
  spec) before I see the menu with the delete option.

Proposals-->Allocation Requests-->Observation Specification
-------------------------------------------------------------------------------------

- Missing Sources.  See "Test Proposal E".  For one AR I created two
  CRs.  The first CR "GBT Spectral Line C-band" has one field source
  and one spectral spec.  After this is saved the Observation
  Specification is created and looks okay.  I then created the second
  CR "GBT Spectral Line W43 L-band" which also has one field source
  and one spectral spec.  After this is saved the Observation
  Specification does not include the new source, etc.  I thought this
  worked before.  N.B., I did not (ever) see the popup message
  indicating the Observation Specification was created which was in
  v0.1.

Allie (Firefox,redhat)

Home page

• +Proposals gives error but does take me to the proposal page. I screen capped it.
• the "view" button on the proposals also takes me to the proposal page

Proposal Page

• New "List" and "Add" Button left side
• Filtering on State doesn't work
• Filtering on solicitation works.
• Created a Proposal with a title and solicitation specified, went back to list and can see it in the List mode.
• Added another Proposal. It pre-populated with the same title and semester selection as the first one instead of being blank. Save button isn't available. The form is hanging. On refresh, the Proposal is gone, which is expected as it didn't save. I added a new one again and it now has a blank Title and Solicitation, which is desired. Not sure why the first time it got hung up.

Proposal Creation (Basic Information, Sci Just)

• When first creating a proposal, it just wants the Solicitation and a Title.
• Once the formed is saved, it will expand to Abstract entry and author widget. The Sci Just and Allocation Request Tabs are also now available and actually look like tabs. The layout is nice so far.
• If I enter in an abstract but do not save it and try to go to the Sci Just tab, a warning appears prompting me to confirm to discard my unsaved changes. nice.
• I can upload a pdf and delete it. I do see the preview and "view" of the pdf, as I am on linux with firefox.
• When I uploaded a different pdf after deleting the first, I no longer have all the buttons. The system Messages say it was uploaded, but the interface looks like it is not uploaded. Refreshing solves the issue and I can see my pdf. I can upload a new pdf as well and it seems to work fine.
• When creating a new proposal that hasn't been saved, the only way to "back out" of the process is to hit the Home tab. Selecting the Proposal tab does nothing.

Allocation Requests

• Entering the AR tab for the first time appropriately says "No ARs". The add button is the same as before. It does not give the List button because there aren't any ARs I suppose.
• The List Proposal Button IS available however, as well as the add proposal button. That may trip someone up at some point.
• Adding an AR shows a view with just the Facility selector - as usual.
• Once the Capability Request panel and add button are available, the Capability Request vs Observation Specification views are also available. They are the familiar square tabs on the right of the screen.
• I like that the Basic Information, Sci Just, AR are clearly tabs and the CR vs OS is a different style. It makes more sense to me because we are toggling to the OS view inside the AR tab. While the CR has tabs as well.
• For the DDT solicitation, the GBT Spectral Line capability is the only one available, as expected.
• For the Semester solicitation, VLA and GBT facilities are available, as expected.
• I can rename the Allocation Request
• I can delete ARs

Capability Requests (DDT, GBT)

• I can make a crazy long name for a field source. Doing so will cause the tabs on the left with the different field sources to expanded until finally it wraps at the page edge. As it expands, it forces the field source, spectral spec (Etc) tabs to compress to the right. At the line wrap, it forces those tabs down a row and any newly added field source create those tabs above the form entry. I screen capped this.
• Field Source, SS, CP, PP do not appear to have different behavior. I can navigate between them without hitting save and I do not lose information.
• Saving gives the familiar prompt. Now the CR view tab has a "1" next to it immediately, indicating that there is 1  CR. In v0.1, it would show 0 even though there were 1+ CRs. I wasn't ever sure how to trigger the change. The OS doesn't now have a number next to it. Not sure if it should or not.
• Saving make the tab view switch to the first tab, regardless of where I hit the save button at. In this case, it is field source. However, it has been noted that the tab order changes and the trigger is not known.
• Go to (A) in Observation Specifications
• I can delete CRs
• If I am in the capability request and I select "Add AR", it does add it but it leaves me at the page I am on, which might make someone think it hasn't been added. You have to navigate to the list of ARs to see that it has been added. This is not the case when I add a CR: it navigates to the empty CR right away. Same with Proposals.

Observation Specifications (DDT, GBT)

• (A) A 2 FS, 1 spectral spec CR has generated 2 Observation specifications. The GBT has partitioning in RA. I put Hen 2-10 in for one source in ICRS and Hen 2-10 in Galactic Coordinates for another, so there shouldn't be two OS and really only 1 target source, as they are identical sources except for the coordinate system. The system doesn't handle this yet though.
• The time on source is not correct. I cannot update it either through the Performance Parameters nor the Advanced Tab. — It requires a refresh to see the updated OS.
• Filtering on field source works mostly. It doesn't work on the 0th subscan target.
• Filtering by band doesn't work
• Filtering by intent doesn't work
• The long name on the field source causes the filtering to completely push the scan list down beneath the filter panel instead of just wrapping the field source name.
• The Scans tab has a nice numerical in the tab showing how many scans are in it.
• I can add a scan as previously. There's a save button when I do that and the Status changes from System Generated to User Generated. Nice
• Adding a band and field source is the same.

Capability Requests (Semester)

• This all looks familiar
• As soon as I save an Advanced option, the Performance Parameter no longer works at all.
• Navigating to the list of CRs or otherwise prompts the warning about discarding unsaved changes.

Observation Specifications (Semester)

• If I save, I get the warning about generating a new OS
• When I go to the OS tab, it almost always prompts me again saying there are unsaved changes. But there aren't unsaved changes.
• Filtering doesn't work at all here? Had to refresh and now it works just fine, even band and intent.
• Submitting generates an error. The button is available though

Dana (Firefox, fedora)

-------------------------
Dana Balser_TTA |
-------------------------

Home
--------

- The solicitation are both open and recently closed.  This makes no
  sense.  Maybe this is just an example of what the TTA member will
  see.

Solicitations
------------------

- Looks good.  Sem_25A has both VLA and GBT Facilities and all bands
  (L-Q), whereas SC_GBT_24B has only the GBT and L,S,C bands.

-------------------
Dana Balser |
-------------------

Home
---------

- I only see the open solicitations.

Proposals
--------------

- A bit slow going from Home to Proposals.

Proposals-->Basic Information
------------------------------------------

- Looks good.

Proposals-->Scientific Justification
-----------------------------------------------

- This looks okay.  Might alter text (e.g., replace "5" with "x" since
  this will depend on the Proposal Class).  

"Each proposal should include a Scientific Justification as a pdf file.

The Scientific Justification should outline the scientific merit
expected if this proposal is awarded time on it's requested facility.

The pdf file should be no more than 5 pages."

- Functionality appears good. Able to upload/view/delete pdf as
  expected.

Proposals-->Allocation Requests
---------------------------------------------

- This looks okay.  Might alter text.

"Create at least one Allocation Request for each facility you would
like to use.

Time is awarded on a facility per Allocation Request. Awarded time on
a Proposal may only be applied to some of it's Allocation Requests.

If there are multiple acceptable configurations that can meet your
science goals (e.g. minimum required configuration, ideal
configuration), create an Allocation Request for each one to increase
the chances of getting awarded time."

Proposals-->Allocation Requests-->Capability Request
--------------------------------------------------------------------------

o Proposal: Probing Molecular Cloud-HII Region Dynamics using the OH
  Satellite Line Flip (Sem_25A)

- This proposal was a very simple setup.  Just edited everything by
  hand.  One Capability Request (VLA continuum) that included just one
  field source and one spectral spec.  Edited everything first and
  then hit the save button.  Pop-up message was nice to let me know
  that the observation specification was created.

o Proposal: Multi-Configuration, Multi-Band VLA Proposal (Sem_25A)

- This proposal is more complex.  Two ARs (e.g., different array
  configs for TAC).  Each AR had the same setup of two capabilities
  (different bands: X, Ka) and fields sources that should be divided
  into two groups on the sky.

- Noticed that the spectral spec for VLA continuum has bandwidth and
  spectral resolution.  This is a bit confusing since this is not
  spectral line.  Presumably the time exposure calculation uses
  bandwidth since this is continuum?

- When manually entering 40 (in arcsec) for the LAS in the spectral
  spec the following was displayed: 39.999999599999995.  If I leave
  the page and come back the units are degrees.  I think this is
  expected since we agreed for v0.1 that we would show the precision
  necessary for GMVA at W-band and angles are stored in degrees.

- Explored the Advanced tab a bit.  Interface seems reasonable.  I can
  edit any single field source/performance parameter or there is a
  utility to update the performance parameter for all field sources.
  I looked at the input file format but did not experiment.

o Probing the Warm Ionized Medium toward the Inner Galaxy (SC_GBT_24B)

- This proposal is for the special GBT call.  I only see the GBT
  listed as a facility as expected.

- When I enter "-11:29:18.9808" for the one field source Dec it
  displays -12° 30' 41.01920".  This was repeatable.  But when I
  entered in other numbers for other field sources it seemed to work
  fine.  Odd.

Proposals-->Allocation Requests-->Observation Specification
-------------------------------------------------------------------------------------

o Proposal: Probing Molecular Cloud-HII Region Dynamics using the OH
  Satellite Line Flip (Sem_25A)

- I specified NO polarization calibration yet there exists a
  Calibrate_Pol_Angle scan. This appears to be a bug.

- The integration times appear to be fixed.  Changing the rms
  sensitivity does not change the time on source.  I recall that we
  set these to a "reasonable" fixed number when the calculated time
  was really small.  Indeed this appears to be the case.  If I reduce
  the rms sensitivity I can see the time change.

o Proposal: Multi-Configuration, Multi-Band VLA Proposal (Sem_25A)

- Okay, for each AR I get four different Observation
  Specifications. They are organized into two source groups for each
  band.  This is reasonable.

- Integration times are not quite what I expect.  If I use a frequency
  of 9 GHz, a bandwidth of 4 GHz, and rms sensitivity of 10 microJy
  then I get an time of 2m40s.  From the ECT I get 4m27s.  Factor of
  1.7 more time on science target.  Probably okay for v0.1.  The time
  does integrate as expected.

- The science target scans tend to have rather small integration times
  (e.g., 3 minutes).  So if the total time needed on science target is
  large (e.g., few hours) there are many scans and thus the overhead
  is also much larger than needed.  I recall, as noted above, that we
  fixed this under certain circumstances but not sure why that is the
  case here.

- Explored the effects of changing the sensitivity for one field
  source in the advanced tab of the Capability request.  This does
  change the time on source in the Observation Specification but it
  changes all of the field sources instead of the single one that I
  altered.  This seems to be a bug.

- Explored changing the Observations Specification.  Not particularly
  intuitive but will probably server the purposes of V0.1.

o Probing the Warm Ionized Medium toward the Inner Galaxy (SC_GBT_24B)

- Not convinced the integration times are correct for the GBT.  I have
  entered an rms sensitivity of 0.001 Jy/beam (1 mJy), spectral
  resolution of 1 km/s, and a frequency of 6 GHz.  I estimate about 3
  hours on science target from the Python script I wrote, but get 0.1
  sec from the tool.  My guess is that the bandwidth is being used to
  calculate the time instead of the spectral resolution, which is what
  I would expect for spectral line.  The bandwidth is 100000 km/s
  which yields about 0.1 sec, consistent with the tool.  So this is
  the issue.

Allie - redhat, linux

• Copy Edit Changes:
  • Home Page, when logged in as TTA member - Recently closed solictations mirror open solicitations currently
    
    • Fake text or Add a solicitation that is closed to show the purpose of the region but isn't mirroring the open soliciations
  • Scientific Justification - yellow instruction box should read:
    • This region can be customized to contain instructions for the proposers. An example dialog is ".pdf only; font size no less than 11pt; no more than 4 pages (including figures, tables, and references). Maximum file size: 16 MB
      The science review panel members are instructed to reduce the score of any proposal that does not abide by these constraints."
  • New Allocation Request- yellow instruction box should read:
    • This region can be customized to contain instructions for the proposers. An example dialog is "A proposal requesting resources from multiple facilities requires at least one Allocation Request per Facility. See the online guide for suggestions and guidelines on how multiple Allocation Requests per Facility can convey your top priority concerning the requested resources."
• Proposals Tab
  • When logged in as TTA member, I do not have "My" proposals. I understand the profiles are not linked. Noting to remember to put into document to not expect that behavior.

Allie QA v0.1.1 on prod

• STT-1001 updated how time is distributed in the scan list because there is no concept yet of a repeat count on the OS.
  • For the GBT, all of the Requested Time is held in 1 scan/subscan. The default setup time is 6 s. This is the general behavior I see.
    • When I put in a really large BW and large RMS, the displayed time in the scan list and the  Time per Science Target Tab show 0s. This is because the real time is quite small I believe. This should either default to a minimum of some value (TBD) or display the time, even if it is small
    • Has the Calibrate Pointing and Calibrate Focus Target always been called "0th Subscan Target?". The source should the same as the first Science Target (STT-612)
  • For the VLA, we are showcasing a simple interleaving of the phase calibrator. However, we have limited the number of scans generated per Science Target because the scan list was getting unwieldily without the repeat count concept.
    • The behavior is
      • If the Requested Time is less than 90s, all of the time is held in a single scan/subscan.
      • If the Requested Time is > 90s, then three scans are created and the time is split evenly between them.
    • Similar to the GBT case, if the time is very small, the acquisition time on a subscan shows as 0.
    • The default setup time appears to be 1m 40s - not sure why it is different than the GBT case.
    • The Requested Time seems to match the sensitivity calculators, though the GBT is using bandwidth instead of the spectral res to calculate time.
    • The behavior is not as I expect:
      • Either the setup time is being factored into the decision to create 1 or 3 scans or three scans are always created regardless of the requested time.
      • For example, a source has a requested time of < 90s, so I would expect 1 scan in the Observation Spec. However, 3 scans are made instead, each with a very small amount of time and 1m40s of setup time. I have only tried a few iterations but I'm having trouble getting just 1 scan to be created instead of three, so something is up.

Allie (Firefox, redhat)

Note! 20D Solicitation only has specific hardware for the facilities.

VLA has Ka- and L-band. GBT has P- and K-band.

• Landing page
  • Can edit a message of the day as a ttamember and save it. The save feature doesn't give useful feedback: it would be nice if a system message were displayed and the button changed somehow to reflect that a successful save had occurred
    • Logging in as a different non ttamember does show the message I wanted to save.
• For the iteration that goes in front of the TTA group, it would be good to remove the notification on the review tab, since that doesn't go anywhere right now.
• If I log out from a profile, it doesn't redirect anywhere. It should probably redirect to the landing page. It just sat and tried to load the proposals, which is the page I was at when I hit the log out button.
• Solicitation Tab should not be available for non TTAmember or it should be different as non ttamembers are not modifying the solicitation.
• Proposal with a realistic looking solicitation
  
  • Basic Information works as expected.
  • Scientific Justification
    • Tried to upload a 3.1 MB pdf. Got error messages of " A backend error occurred. Request Entity too large at api/proposal/6/sciencetific_justification" and "http failure response for https://tta-test.nrao.edu/api/proposals/6/scientific_justification:413 request entity too large" but then I also got the message that says "file uploaded" and I can see the file in the scientific justification view. If I exit the proposal and load it up back, the Scientific justification does not persist.
    • The view button works
    • The delete button does not actually delete it. It also gives an error of "http failure response for https://tta-test.nrao.edu/api/proposals/6/scientific_justification: 401 unauthorized"
    • Replace the file does work but I get the same errors as above. this file is 2.2 MB in size.
    • I uploaded a png just to see if it would allow me to do so. It does allow a png to be uploaded.
  • Allocation Request
    • Selected GBT and GBT Spectral Line; reloaded after creating the allocation request to try to avoid the error discussed on Tuesday.
      • Maybe I didn't hit it in the right order, as I was not able to save the Field Source I created. I had to refresh first and then I could reenter the field source information and save.
    • I could not delete the only Capability Request in the Allocation Request.
      • I got the error "Could not remove Request from Proposal"
    • Field Source
      • Mostly works as expected except there are red boxes, indicating problems, around negative numbers like for radial velocity, declination.
      • The hexadecimal view of the RA gives the minor error of "only enter numbers" when the hour, minutes, seconds are used to differentiate the inputs. It saves despite this error though.
      • The precision on the conversion looks off.
      • RA should only have options of Degree & HMS
      • Dec should only have options of Degree & DMS
      • Parallax should only have degree, arcmin, arcsec
      • The units on the Flux Density fields are should not be per beam if they are actually meant to be flux densities and not intensities.
        • It would be nice to other Jy as an option for input to these fields too
      • FOV Shape
        • It's really nice that the field for FOV in RA/ FOV in Dec will change with the coordinate system.
        • The units here should only have degree, arcmin, arcsec and we need to be clear if we really do mean arcmin and not minutes, even for the RA field.
      • Proper Motion
        • The proper motion titles also change with the coordinate system. We need to be very clear about this I think or restrict this ability because proper motion in Galactic is not equal to that in RA. There's a transformation between them I do not think we want to be responsible for it. Did we decide if we were responsible for coordinate transformations in general? I think ALMA puts that on the observe and I recall that's what we decided.
      • I don't think it is useful to have the up and down arrows to change the numbers for any fields here because the precision on that function is an issue and will change between fields. Plus, right now you can adjust it to be a negative number for fields like FOV, which should never be allowed to be negative.
      • There should be a better error message if a negative number has been entered into a field that cannot be negative instead of the current error, which says "only enter numbers".
      • It would be nice if there was a mass select or delete on the field sources.
      • Importing field sources somewhat works
        • The import widget is nice and does a good job at assigning the columns
        • The RA and DEC entries were in hexadecimal format and did not propagate to the fields properly at import.
        • The Proper Motion, parallax values in the file are 0 and the widget shows no values for them, so it is unsurprising that there are no values in the Field Source entries. However, 0 is a valid entry.
        • I appreciate that on a new CR, there isn't a "dummy" field source that is created right away and I need to delete, particularly after the import. That being said, I would think I would be able to delete all the Field Sources to start anew without having to delete the CR.
        • The units on the import file are not matched to the fields. I imported in Jy and of course, the field for continuum flux density is microJy. This is also a problem in other fields.
        • Importing Galactic Coordinates seem to work correctly.
        • Import of different field of views work
        • Uncertainty in Ra and Dec fields should be removed from the import list
        • I suspect coordinate epoch should also be removed from the list.
        • Importing seems to handle mixed coordinate systems well.
    • Spectral Specifications
      • It would be nice if it were possible to enter in center frequencies with units of MHz too; likewise, the bandwidth in and resolution could be entered in as Hz, MHz, GHz
      • These fields are highlighted in red when a negative number is entered, which is good as they aren't allowed to be negative. It would be helpful if a message were also displayed or the bang that appears with the red highlighting had a hover over tool tip to explain the error.
        • Despite having negative numbers here, I can still save. That isn't a good behavior.
      • Importing a spectral spec works as expected.
    • Performance
      • Performance should really be Performance Parameters, which is what it is called in the documentation and consistent with how we call Calibration Parameters.
      • The Units on Angular Resolution should be deg, arcmin, arcsec
      • It would be nice if the rms sensitivity also had Jy/beam or mJy/beam options
    • Advanced
      • There should be units on Angular Resolution and RMS Sensitivity here
      • Eventually it would be nice to have a tool tip explaining what the eye is, as it may not be clear right away. Also, it isn't centered under the word observe.
      • The filters aren't filtering the list view; partially works for the 20D solicitation
        
        • What do the question marks in the filter view mean?
          • I think it is trying to fill the position but cannot do so here. In the OS, it has the position of the source in this area of the widget.
        • the filters only work if i select a FS and SS, so I can't just select all of a SS or all of the FS.
      • After modifying in the Advanced view, I can save.
    • First pass at generating OS (Sam says realistic looking proposal is broken)
      
      • with a seemingly acceptable proposal gave an error of "could not find of generate observation specification"
      • STL is not available. has system error of "a backend error occurred. internal server error at api/science_target_list/5".  I tried refreshing and still was not able to view it or the OS
    • Science Target List
      • Should only be viewable to a TTA member
    • Future testing thoughts:
      • Future question for testing: if the Obs Strategy is going to try to merge FS+SS that are similar, what happens when two entries with the same coordinates have other attributes that are different like FOV, peak Flux Density, line width?
    • General:
      • I caused the system to hang after uploading a spectral spec and filling in performance parameters. The FS entries weren't all correct so I refreshed and tried again. I fixed the field sources entries, didn't hit save, went to SS and saw the system was hanging again. When I went back to FS, it hadn't persisted the parallax field but did persist the proper motion fields.
        • Despite refreshing, the system still continued to hang on a save.
        • I deleted the allocation request and begin a new. I clicked to add a CR and got the system error "a backend error occurred. internal server error at api/capability_requests" then quickly followed by "Could not create a new Allocation Request"
        • This proposal seems to be stale now and I cannot add allocation requests to it anymore. Even when I back out and come back to the proposal, it will not let me add AR.
        • I was uploading and deleting a lot of Field Sources before this happened. Maybe it didn't like that?
        • I made a new proposal and still cannot seem to make AR. I can upload Sci Just though. I had to logout of the user and log in again.
      • At some point when I was editing FS, the CR had a banner that said Changes Pending, which I expected. But then the Allocation Request also got a banner with Changes Pending that didn't go away until I hit the save button associated with the Allocation Request. Typically, I only see a banner for the CR when I am editing FS/SS/etc and not one for the Allocation Request. I have no idea how I triggered it.
      • I am not convinced that Proper Motion and Parallax fields are persisting properly. There is no predictable behavior for when the fields are turned to null but it happens frequently, despite not being given values of 0.
• GBT proposal with a 20D solicitation
  
  • Sci Justification has similar errors
  • Allocation Requests
    • So far all issues I found in the realistic-looking solicitation apply here
    • Calibration parameters
      • Polarization Calibration is missing its button. The text is still here but there is no button.
    • I still cannot generate an OS or STL – it is because I was requesting SS that aren't available to the Solicitation. They did say this, I just didn't intake it apparently.
• VLA proposal with 20D Solicitation
  • Sci Justification has similar errors
  • Allocation Requests
    • Field Source
      
      • • Importing Sources
      • Radial Velocity was imported  NaN when I mistakenly assigned the wrong column to it. It tried to give is a string instead of a number. So that rather works intuitively.
    • Spectral Spec
      • Import works
        • Units on spectral resolution and bandwidth should be defaulted to MHz or at least the option of changing to that. Will we be responsible for the transformation? I think that's simple enough.
    • Performance Parameters
      • There is not field entry for Angular Resolution and there should be.
    • Calibration Parameters
      • Polarization Calibration is missing its button here too.
    • Advanced
      • Angular Resolution doesn't show up as an option to be changed in this view, nor is there a display for it.
      • The upload here works as I expect. Though I added 2 "ringer" sources and it did not give the prompt that it couldn't match them to anything. It did bring that up for two sources that I had deleted.
    • Observation Specification
      • If I request the right bands (Ka-, L-band) then this works
      • Filters
        • Filtering doesn't work properly in all the tabs. I think it works correctly in the Science Targets and Observing Target tab but not in the scan tab.
        • I think Target should be changed to Source in the filter
        • The "Bands" filter reflect the Hardware Configurations the system decided; should the name be the system's name for the band or how the user's SS was mapped to the band?
          • Otherwise, there is no inclusion of the user's name for the SS anywhere in the OS.
        • Instead of, or in addition to, the position in the filter, it might be more useful to have the pointing pattern that the system is going to use. For example, if the user enters a FS in the CR that is clearly meant to be a mosaic, that information would be more useful than just the position. That would align with our definition of a Source, which has a name, a nominal position, pointing pattern.
        • The positions attached to the filter cards need attention in their precision. Also, they directly reflect the FS position so they are a mix of coordinate systems but it doesn't actually specify it. They should also have units.
      • It created 2 OBs split in frequency. I didn't think it could, or should, do that yet.
      • Total Time on Observing Targets is reporting NaN s.
      • Adding to the OS
        • I can add a scan and assign the new FS to it. This very different but i think I get it and it works as expected
          • The exception in the setup time. The user would not specify this because it depends on the slew. We don't want live updates on this though I think. Instead there should be a way to validate to get the updated slew times. Maybe as soon as an edit occurs, any time estimate except the acquisition time and the total time on science targets should be voided until the system is called? Is that a behavior we're going to have is the first question I suppose.
        • The STL doesn't reflect the addition of the ringer, which is consistent with the behavior I  expect. The STL is not to be regenerated from the OS.
        • My added target did not persist in the OS when I moved away from the OS.
        • I cannot add a SS
        • Once I modify the OS, it should change the status on the OS from system generated. It should be more evident that this is no longer a purely system generated OS.
          • Toggling off the OS page should also warn me that the CR is out of sync now with the OS.
          • The manual edits to the OS should persist.
          • There should be a warning in the CR if they are out of sync that I will rewrite the OS.
          • There should be a button that clearly indicates I am generating an OS or something. Otherwise, how do I force a new OS to be generated from the CR? It cannot be just toggling back and forth between the OS and CR tabs, as I may want to do that without overwriting the edits I made to the OS.
      • The coordinate transformations are not correct in the OS: the conversion between Equatorial Coordinate System (RA,DEC) and Galactic coordinate is not correct for example. The RA coordinates of the calibrators do not match the JIRA ticket. Something went wrong there.

Dana (Firefox, fedora)

User: Jane Doe.   Solicitation: 20D.   Proposal: Direct Measurement of the Expansion of UCHII Regions.

• Allocation Request 1 (Facility Real VLA)
  
  • We should probably change Facility "Real VLA" to "VLA"
  • Capability Request
    • We should probably change "Real VLA Continuum" to "VLA Continuum".
    • Field Sources: Keyword names have changed but that is okay.  Epoch can be input via file but is not displayed.
    • Spectral Specifications: Looks okay.
    • Performance: No textbox is present to enter data for Angular Resolution.
    • Calibration Parameters: No yes/no switch for Polarization Calibration. 
    • When I click "Save" I get the following message:  A backend error occurred. 'Not Found' at 'api/capability_requests/64.  I get spinning icon.  Have to go to Home and then back to Proposals.  Started from scratch and was able to save the Capability Request.  Still had same issues above.   Created another Capability Request and had to go through the same steps. 
    • Tried to change the Capability Request name.  Ran into the bug Reid highlighted at the Sprint Review.  Go to home and back and you can see the new name.
  • Observation Specification.
    • Two Observation Specifications are created.  One for each Capability Request.  Looks okay.
• Allocation Request 2 (Facility GBT)
  • Capability Request
    • Field Sources: okay.  Now we see "Peak Line Flux Density" and "Line Width" in the file import.
    • Spectral Specifications: Looks okay.
    • Calibration Parameters: No yes/no switch for Polarization Calibration.  
    • Performance: okay.
    • Note that the tab order is different between the VLA and GBT (Calibration Parameters and Performance are swapped).
  • Observation Specification.
    • One Observation Specification is created.  Looks okay.  The calibration is done at Ka-band and not K-band.

Dana (Firefox, fedora)

• General
  • The message of the day feature seemed to work as advertised.  Overall, I did not see any significant lags.  I then created a new proposal as SallyScientist called "The WISE Extension of the HRDS".
• Basic Information.
  • Seemed to work okay.
• Scientific Justification

  • When importing the sj PDF (2.8 MB) I get the following error message: "A backend error occurred. 'Request Entity Too Large' at 'api/proposals/37/scientific_justification".  I was able to import a smaller sj PDF (0.445 MB).

• Allocation Request
  • Capability Request
    • Setup 200 field sources and 1 spectral spec.  When saving I got the following error message: "A backend error occurred. 'Request Entity Too Large' at 'api/allocation_requests/68".   When I reduced this to 50 field sources the Allocation Request was saved.
  • Observation Specification
    • In general this looked okay.  I could see the hardware and OI names, etc.  Need to decide better names for all of this but okay. But I noticed that there were only 51 targets.  I expected the 50 science targets plus 3C286 and test A for a total of 52.  Field source 12 was missing (HII0012).  Closer inspection revealed that since I did not have sufficient precision in my input file for the RA/Dec that field source HII0011 and HII0012 had the same coordinates.  A bit surprised that the software would recognize this fact and decide not to observe HII0012.  Probably best to not do this but warn the user that two field sources have the same coordinates.

Allie (Firefox,redhat)

• General
  • Toggling between basic information and allocation request has a lag of about 1~2 seconds before the information is shown. It almost looks like a blank proposal at first before it loads. I have 50 FS and 2 SS and I generated the OS before trying to toggle between them.
  • (Feature) there should be a warning when switching between these views if the input data isn't saved.
  • Message of the day is editable, saving, and persisting. There isn't an indication that it is saved or edited though when a ttamember.
• Allocation Request
  • Capability Request
    • Import of FS and SS mostly works as expected except when the value is 0, then nothing is populated into the FS.
    • (Feature) there should be units attached to the TOM inputs.
    • (Feature) it would be nice to have an easier way to delete FSs en mass.
  • STL
    • The name of the SS is not propagating to the STL. Instead only the mapped Hardware Configuration name is shown.
  • Observation Specification
    • Second Dana's comment.
    • The name of the SS isn't propagating to here either.

Dana (Firefox, fedora)

• Allocation Requests
  • Overall the layout is better organized and therefore easier to navigate.
• Capability Requests
  • Some of the functionality here is a bit different than for Allocation Requests.  For example, (1) the way to list the different Allocation Requests or Capability Requests; and (2) the functionality to rename the Allocation Requests and Capability Requests.  I prefer consistent functionality but understand there are trade-offs.
• Target Overrides
  • I think the functionality of this tab should be incorporated into the Capability Request tab; effectively we are fine tuning the Capability Request.  Need to make the flow more clear; e.g., user has to intuitively know that they have to mash the Generate Observation Specification button.
  • The labels here are numerical (1, 2, etc.) but under Capability Request they have names so the mapping is not clear.
• Observations Specifications
  • Not sure why the calibration scans are at Ka-band, whereas the science targets are at C-band and L-band.  Maybe legacy stuff from the VLA?
  • Not clear to me we want the scan and subscan intents to be so prominent in the display.  I tend to want to locate the source name and found this a bit hidden at first.  Need to think about this since the intents are important and I may just be biased here from past experience.
  • The subscan intents are a bit confusing to me but are implemented as described (STT-441).  Need to discuss this with the product owners.
  • Not clear we should include the test source as a science target (e.g., as displayed under Total Time on Science Targets).  But again, this is implemented as described (STT-441).
  • I suspect we will eventually want the observing procedure, what I think we are calling the pointing pattern, displayed.  But we have not gotten to this yet.  Anyhow, just something to think about vis-a-vis the real-estate as the displays are getting crowded.
  • It would be useful to be able to collapse each Observation Specification; again similar functionality that exists for Allocation Requests and Capability Requests.

Allie (Firefox, redhat)

• General
  • If a CR has generated an Observation Specification and then I delete the CR, the observation specification (TOM+STL) are still available. There should also be a warning that you are deleting the CR, which will modify the OS. Generating a new CR then overwrites the previous OS, I think.
  • I think 50 FS and 1 SS has caused enough of a load on the system that the navigation is noticeably slowed down.
  • For science side - I think it would be good to have a tooltip that has more detail about the scans. For example, we thought the OS was wrong because a calibrate flux scan had two on_source subscans. If it were a OnOFF OI, then we would have on_source/off_source. But this is a GBT Nod OI, where both subscans are on_source. You wouldn't be able to tell that though from the scan list. To have transparency in the scan list creation, because the user doesn't see the algorithm work, we need more information on the OS. That way, the user knows where to refer to in the algorithm document.
• Capability Request
  • When I first open the CR, it has an empty FS and SS in the CR. When I upload a file, I keep forgetting I need to delete that first entry. Not deleting the first (and empty) entry causes an error and my inputs are wiped out.
  • Is there a way for persisting the entries even if an error occurs on the save?
  • I think the Calibration Parameters should have defaults. Maybe the first entry, instead of being empty could have a working example filled in?
  • Field Source Parameters in the GBT capability are not persisting even after a save. I thought they should in the GBT case.
• Observation Specification
  • I recreated the 50 Megamaser's usecase as a CR via upload. I expected the partitioning function to partition the 50 FS into 2 OS's. It does indeed do this. It isn't obvious when multiple OS are created though, as they are down at the bottom (future task to revisit this).
  • The RA for the calibrators is a decimal hour but the RA for the Science Targets is in Degrees. These should have the same units of degrees. Even worse! the same calibrator (e.g., 3C286) has decimal hours in the calibrate flux scan but decimal degrees in other scans.
  • The peak scan is there but is called calibrate pointing. This is a discussion for scan intents with GBT.
  • The scans numbers are showing an incorrect previous state, even when I have not moved scans around. I think I triggered it by filtering by intent. All the previous states say "1".
  • Band and Target Filtering doesn't seem to work. Filtering by intent almost works but it thinks the science targets are calibrate_pointing scans and observe_target scans and vice versa.
  • I believe the total overhead calculation is correct.
    • The Setup Time should eventually have the Slew Time +Hardware Overhead Configuration
  • I don't quite understand why Ka band is on the calibrators when the usecase hard coded K. The uploaded file asked K and the Science Targets have K instead.
  • An Undo button would be nice. Particularly when deleting scans.

Live notes from Sprint Review

• Bugs:
  • Numbering on sorting in Obs Spec for Scans
  • Some Calibration Parameters are not propagating to ObsSpec  STT-729 - Getting issue details... STATUS
  • Firefox doesn't display the SciJust quite right  STT-721 - Getting issue details... STATUS
• VLA and GBT should have similar flows
• Disabled making new Targets in the Obs Spec tab for now.
• Can make subscans and filter on them.
• Will create drop down menus for the subscan intents and similar items STT-725 - Getting issue details... STATUS .
• Currently VLA calibration strategy service looks like the GBT calibration strategy service for now because VLA cal plan service needs updating to the level of GBT.
• Cannot delete field sources/ spec spec if it is the only entry.
• Saving a bad capability request no longer breaks everything. It can be updated now and you do not have to start over completely.

Allie (Firefox, redhat)

• The Field source input for RA in HMS should not be h ' '' but h m s, as min != arcmin and sec != arcsec

Allie (Firefox,redhat

• Expectations
  • A realistic-looking solicitation can have Real VLA or GBT proposals.
  • It should be possible to upload a config file for Solicitations, Fields Sources, and Spectral Specs
  • There should be minimal differences between the CR→ TOM→ STL→ ObsSpec between VLA and GBT now
  • Unit conversions for angles should work but coordinate conversions do not (and perhaps are never expected to)
  • I should be able to deleted FS and SS in a CR without deleting the whole CR
  • All Field Source parameters are on display because the superset was implemented but not the masking based on capability
  • Entering in Long/Lat is finicky and under review STT-714 - Getting issue details... STATUS
• Solicitation
  • System is hanging when i am trying to upload the supplied json file (but with a new name)
• Capability Requests (JaneDoe Sprint30 Proposal1)
  
  • VLA Continuum
    •  Something made the system hang after I entered in one field source and hit save Allocation Request. I had yet to enter in Spectral Spec, so maybe that's the problem? I would like some type of confirmation that it's saving my progress regularly or on demand so I don't enter 100 field sources and then lose it all.
    • All but the coordinates and name are being cleared from the FS entry. The coordinate system is also being reset back to ICRS it seems.
    • Sometimes the TOM is automatically adding back a source that I am trying to uncheck the Observe button for. Sometimes the TOM won't let me add a source back in. The system is hanging somewhere.
    • If the input is ICRS, degrees
      • The TOM is displaying in DMS for both long/lat coordinates
      • The STL is displaying hourangle (Decimal)/degree
      • The OS is displaying HMS/DMS
      • The conversions appear to be correct
      • Declination doesn't like a negative number
      • RA shouldn't allow a negative number.
    • Editing the Sources in the OS
      • Only the name is propagated to the fields in this edit widget
      • Editing the fields seems to collapse the field entry such that I can't see what I put in
      • Whatever format I enter in the edit menu for the coordinates of the field source, the OS directly reflects that i.e., there are now dissimilar display units in the OS.
    • The filtering appears to work in the OS as expected
    • The movement of the scans appears to work (with mouse, with select and move button
    • The ability to add a scan works until I try to edit it and save the edits.
    • Editing the OS directly causes a backend error occurred. ;internal server error' at 'api/observation_specifications'. System seems to hang when I try to save an edited OS
    • I can delete field sources and spectral specs, though the interaction point is completely different than how to delete a CR/allocation request
    • The upload of FS and SS appears to work
      • FS clears all fields when after save except for name and coordinates.
      • If the first FS or SS is empty, it does not override it and leaves an empty FS/SS in the list.
    • STL doesn't always generate properly from TOM. The OS seems to reflect the STL.
    • If duplicate SS are entered/uploaded to a CR, the TOM display duplicate entries. It's hard to tell if the STL would also do this because it doesn't always generate properly anyway.
  • GBT SL
    • The FS and SS entries are not deleted when I navigate around after saving, as they are in the VLA Continuum. Why is this behavior so different between the two CR?
    • Performance has angular resolution here; VLA doesn't? FS has a superset but SS/PP/CP aren't yet a superset perhaps?
    • Not all of the FS are propagating to the STL
    • Something seems to be weird about the requested time calculation. The Display shows 19h19h5m50s so I'm not quite sure how to interpret that.

Dana (Firefox, Fedora)

• Solicitation

  • I was able to import a solicitation.  Not much one can do at this stage but I was able to change the Solicitation name, for example, and this worked.

• Allocation Request
  • I would move "Allocation Request Name" above the tabs (Capabilities, Target Overrides, Observation Specification, Science Target List).
  • When trying to create a second Allocation Request I got the following error: "Could not find or generate the requested item".
  • Capabilities
    • Entering coordinates in HMS format, for example, is a bit funky as discussed at the sprint review.
    • Entering in zero (e.g., parallax) does not persist.
    • Importing a file worked okay for both Field Sources and Spectral Specs.
    • I was able to delete a Capability, Field Source, and Spectral Spec.
  • Target Overrides
    • I had 22 field sources and 2 spectral specs.  I altered the sensitivity for one row (first field source/spectral spec).  In the observations specification, however, all of the scans that included the spectral spec were altered.  Also I reduced the sensitivity by a factor of 2 and was therefore expecting the integration time increase by a factor of 4, but the time increased by a factor of ~20.  ***N.B., I may not have hit the save button.***
    • I tried this again.  Simple case with one field source and one spectral spec.  Here is the procedure:
      1. Target Overrides tab: modified the rms sensitivity from 500 to 1000.
      2. Target Overrides tab: Clicked "Save" button.
      3. Target Overrides tab: Clicked "Generate Observation Specification" button.
      4. Observation Specification tab: view duration.  I expected the time to decrease by a factor of four.  The duration went from 11m34s to 2m58s.  Not quite a factor of four.
      5. Science Target List tab: The time on source, presumably in seconds is not quite the same as being displayed in the Observation Specification tab.  For example, 171.98560615411375 seconds is 2m51.99s.   But the duration here did change by exactly a factor of 4 (from 687.942424616455 to 171.98560615411375) .
    • I used the exact same procedure as above except on a more complex setup: 22 field sources and 2 spectra specs.  I modified the rms sensitivity from 500 to 1000 for only one field source/spectral spec.  Indeed, on the Observation Specification tab and the Science Target List tab only the modified field source/spectral spec duration changed.  Had the same issue with the slight difference in time as noted above.
  • Observation Specification
    • Not sure why the calibrator is at X-band when the target is L-band.
  • Science Target List
    • Using the VLA hardwired values but I think this is TBD.  The coordinates were not converted correctly from front-end to back-end. Started in Galactic but the same numbers are listed as RA/Dec.

Allie: (Firefox, redhat)

• My expectations are
  • A realistic-looking solicitation can have a Real VLA or GBT proposal. The test solicitation is no good for testing?
  • In a Real VLA proposal, I can see the TOM, the ScienceTargetList, and the OS.
    • The capability request can update the TOM, the OS, and STL.
    • Updates to the TOM do not affect the OS.
    • Updates to the TOM should affect the STL.
    • I can edit the OS directly.
  • In a GBT Spectral Line,
    • a more detailed capability request now exists
    • can save a capability request but there is no TOM/STL/OS generated yet.
• Home page
  
  • Clicking on "create proposal" on a solicitation directs to the new proposal page as expected. I have to then specify what solicitation I want again on this page. It would be nice if it auto filled this if I'm navigating from the solicitation on the home screen.
  • delete the trailing quote+period on the Global Millimeter VLBI Array (GMVA)".  line (sprint 24 comment)
• Trying to edit an already created proposal
  • Home → My Proposals Card, blue edit button once I've found the proposal → edit mode activated
    • Difficulty in finding proposal but easy once I do
  • Home → Open Solicitations Card → View Proposals button → click my proposal card → doesn't take me to the proposal. it just takes me to a list view of all the proposals and my proposal is expanded into a new card. The expanded card as the grey edit button → edit mode activated
    • Many screens and scrolling required. The edit button is subtle here.
    • In a previous version, the expanded card would show up next to a list of all the filtered or unfiltered proposals. It tries to do that briefly but then gets shunted to the bottom of the page in my browser.
  • Home → My Proposals Card → View All Proposals Link → click my proposal card → doesn't take me to the proposal. it just takes me to a list view of all the proposals and my proposal is expanded into a new card. The expanded card as the grey edit button → edit mode activated
    • Same issues as previous path.
• Capability Request for a realistic looking solicitation
  
  • Specifications
    • The + button for field source almost looks like it is for the spectral spec instead of adding a field source. Some space between the two might help. Same is true for the + for spectral spec and performance
  • Spectral Spec
    • The units of bandwidth and spectral resolution are wrong
  • Field Source
    • Trying to specify negative values for FOV, Parallax, etc does throw an error once I save.
    • A + in the radial velocity also throws the error "this.answer is null"
    • Adding a new field source but not filling it in throws the same error.
      • How do I delete a field source or a spectral spec?
    • When I collapse the capability request and expand it later, there is a truncation of the wording on any of the check boxes (e.g., coordinate system, epoch) that are checked.
    • I can't save with the null errors and so my changes don't persist if I collapse the capability but the checked boxes do persist? This is expected?
  • Unclear what delete button deletes what. Which one deletes the capability request vs the entire allocation request when I have them expanded?
  • In a GBT proposal for TommyttaMember, I've filled in all the fields; it is returning a null error but not highlighting any of the fields. I did not have this experience when I was in the SallyScientist proposal.
    • I tried a new proposal and it worked this time. I'm not sure why it didn't work before. I was trying to see what would break it at first and I got the null. I changed it all to "good" inputs and was still getting the null error. I fresh allocation request rectified this.
  • VLA Capability
    • In capabilities tab, if I hit save, I believe that updates the TOM, ScienceTargetList.
    • In the Target overrides matrix, do I need to hit save to update the override or does it do it automatically? - I think it's the save button but at first I thought it was the save button from the capability request.
    • I was unsure about how these are saved/updated, so it might also confuse a user, leading them to update or not update inadvertently.
    • When is the ScienceTargetList generated/updated - only when I hit save?  when I edit the TOM?
      • No system message is generated when I hit save on the TOM.
      • My edits to the TOM do not seem to be propagating to the ScienceTargetList. E.g., deselecting a source or changing the RMS sensitivity.
    • Is the band name that I specify in the capability request only in the TOM?
      
      • Should it eventually be in the ScienceTargetList and OS?
    • The source name isn't in the ScienceTargetList. I think it should be.
    • OS
      • When I add a scan, how does it decide how to populate the data? It seems like it's just the first ScienceTarget being filled in and being put at the bottom.
      • It would be nice to highlight this scan as being a change pending, as the scan lists can get really long and it might not be clear that this was the scan added.

Dana: (Firefox, Linux)

• Solicitations
  • I tried to load my own solicitation (gbtSC.json) but got the following error: "A backend error occurred. 'Bad Request' at 'api/solicitations/configure 5/6/22, 3:11:23 PM".  I then copied "a realistic-looking solicitation" and changed only the name (real2.json) and got the same error message.  The system seemed to hang (got the rotating circular arrows).
• Allocation Request
  
  • Capabilities
    • I tried to create a GBT Spectral Line Capability Request.  I was able to fill out all of the parameters (two field sources, one spectral spec, performance parameters) but when I clicked saved I got the following error: "A backend error occurred. 'Internal Server Error' at 'api/allocation_requests/21 5/6/22, 5:23:23 PM".  The only thing I noticed is a red highlight around one of the Declination textboxes that had a negative value (I recall Sam said this was a known issue but should be okay to save to the database).  Again the system seemed to hang.  I had to leave the Allocation Request tab and come back.  Nothing was saved.

Allie: (Firefox, redhat)

• Allocation Requests
  • Creating a second Allocation Request works. At some point though, the ordering of the Allocation Request tabs change. It's happened a couple of times where Allocation Request and Allocation Request 2 will flip their order on the top bar. Spooky. I think it's putting whatever tab I'm currently working on first instead of just leaving the order alone.
  • Capability Request (the tab is called Capability though?)
    
    • When the specification first loads, I can see all the fields but if I click on a particular parameter, it gives a filtered view. Performance doesn't currently have more fields, so I wasn't sure what to do there. It was a bit unclear how to navigate the RMSSentitivty/performance/spatial/spectral filters from there then. I think you can hit enter, which brings up the macro list of parameters (or cycles through the parameters) or you can click again on a parameter to return to the macro list.
    • The save button does save but it also redirects to the TOM right away, regardless if I was done entering in all the fields. For example, I put in one field source and no spectral spec, and it redirected me. As someone who hits the save button as a soothing mechanism/ thought-clearing instinct, this is a bit disruptive. Happily the information in the parameters persists as I navigate around the capability tab. They do not propagate to the observation specification unless I hit the save button.
      • If I enter a parameter in the Capability, go to the Observation Specification, and back without hitting save, the newly entered parameter does persist in the Capability even though I did not save it. I think that's a good thing.
    • the spectral specification
      • the Center frequency field has a helpful tip suggesting I enter in an RA. Bandwidth similarly suggests that a Declination is needed.
    • Should the side bar instead be named performance, calibration, field source, spectral (spec)? RMS is a performance parameter. The other performance parameters are missing.
    • The calibration parameters are missing.
    • (bookkeeping) the Advance Button still exists
    • I can delete a Capability Request. It seemingly still exists in the Observation Specification though and I'm not sure how to get rid of it.
    • If I act like I'm going to delete a Capability Request but then hit cancel when it prompts me to delete it, sometimes a weird error shows up at the top of the screen in red saying that that item can't be found. It's hard to replicate but I have seen it 3 ish times.
  • Observation Specification
    • I think the filters are working as I expect.
    • If I hold down shift to try to multi select, it opens a new window of firefox instead. Crtl causes tabs with the title of "javascript:void(0)" to appeared in my browser. Maybe it's a linux problem?
    • Will there be a way to clear all filters?
    • I can Save the Observation Specification with my changes. It needs a big notice telling the user that the capability request is now invalid though.
    • I'm able to generate multiple Observation Specifications (see TOM comment). I don't have an OS with a lot of scans, but I think it has a nice layout.
      • Since there can be multiple Observation Specifications, should the name in the tab be "Observation Specification" still?
    • The name I put into the spectral spec doesn't seem to show up anywhere in the Observation Specification. It might be good to think more about why we have this field and its purpose, as the observation specification should probably display the actual names of the bands, as it currently does.
    • (bookkeeping) there are two save buttons: the one at the bottom of the observation spec and the one in the edit mode of a scan.
    • Adding a second Capability Request (and saving) did not immediately add it to the Observation Specification. I had to click around a bit and then it showed up finally. I'm having trouble replicating this behavior though.
    • I like that when I'm editing a Observation Specification, it says changing pending for that one and not all of them.
    • I can delete all the scans in an Observation Specification but I cannot delete the OS itself.
    • The column headings on the scan list are not lining up properly.
  • TOM
    • Clicking the button generates a new Observation Specification in addition to the one(s) already in the Observation Specification tab. I know the TOM isn't user facing but thought I'd note it.
    • Once a Observation Specification exists, how do you update it from the Capability Request. Clicking the Generate Observation Specification button in this tab will create a second one that reflects the state of the capability request. (I think this is in Sprint 28: STT-682)

Dana (Firefox; Fedora):

• Allocation Request
  • Capabilities
    • I think RMSSensitivity should be under Performance.
    • I would add "Calibration" to the list (even if just a place holder now).
    • I would order these: Spatial, Spectral, Performance, and Calibration.  This is more in line with how a scientist would think about the flow of information. 
    • After creating a VLA Continuum Capability I tried to create a GBT Spectral Line Capability within the same Allocation Request.  I should not be able to do this since an AR can only have one Facility.  But I was able to do this initially until I saved the Capability Request and got an internal server error.
    • When I save a Capability I am sent to the Target Overrides tab which is a bit odd but okay for now.
  • Target Override
    • Little confused by this tab but I think we discussed this at one of the meetings.
    • Each time I click the "Generate Observation Specification" Button I can see a new Observation Specification, even if I have not changed the Capability Request. 
  • Observation Specification
    • Overall this looks pretty good. 
    • I could not find a way to delete an entire Observation Specification.

Dana:

• Allocation Requests
  • Not sure of the purpose of Target Overrides.
  • Only one Field Source and one Spectral Spec is saved.
  • Advanced button does not seem to do anything.

Jeff:

• Why are there no Specifications under the VLA Continuum (is this a configuration issue for the solicitation or something else)?

Dana:

• Home
  • I can now see the Solicitations without logging in first.
• Allocation Request

  • When in edit mode, if I click the Allocation Request tab (on left) I see "Allocation Request +Add". My intuition was that I had to click the "+Add" to create an Allocation Request, but if I do this it creates a second Allocation Request. What I should have done was to click "Allocation Request" to start filling in the first one.

  • Not sure if there was suppose to be any way to input information for the VLA Continuum Capability.
  • I still cannot save an Allocation Request, but I can delete one.
  • When in edit mode, if I cancel (click the "x" in the top right-hand corner), I am brought back to the view with the 2-D layout of cards. I would have expected to see the view with the 1-D column of cards on the left with the proposal that I just cancelled on the right.

Allie:

• Home page
  • delete the trailing quote+period on the Global Millimeter VLBI Array (GMVA)".  line
  • is it necessary to have two different create proposal buttons? For example, would the button next to the open solicitations automatically have that solicitation checked?
  • How is the priority set for the list of proposals in "My Proposals"? The newest created proposal is not at the top of the list as I would expect.
  • TonyattaMember and TommyttaMember have different home pages. Is this expected behavior because they have different profiles?
• Editing a Proposal
  • Allocation Request
    • When I add a Capability to an Allocation Request, the changes pending bar behaves as expected: the bar does appear until I make changes. It does not go away when I hit Save though. The save button doesn't appear to work. Maybe that isn't implemented yet.
    • When I make multiple Allocation Requests and then try to delete one, it sometimes deletes all of them instead. I'm having trouble consistently replicating this behavior but it did happen at least 4 times.
    • Is this expected behavior?
      • Create Allocation Request and Allocation Request 2
      • Delete Allocation Request
      • Add an Allocation Request makes a new allocation request with the name of "Allocation Request 2" such that now there are two Allocation Request 2s.
      • When adding more Allocation Requests (AR 3, AR4), the tabs reorder themselves as
        • AR3, AR4, AR2, AR2
    • Capabilities do not persist when switching between allocation requests (maybe the aforementioned save issue?).
    • Cannot rename the AR or the Capability
  • Clicking between "Basic Information", "Scientific Justification", "Allocation Request" very briefly changes the wording at the top left from "Edit Proposal" to "New Proposal" and back again to "Edit Proposal".
  • When clicking back to "Basic Information" from "Scientific Justification" or "Allocation Request", the check box with the "test solicitation" sometimes briefly displays the words "[object Object] " instead.

Dana:

• Home Tab
  • Looks better. Need to think what we really want here. If we list Open Solicitation maybe we should list Draft Proposals instead of My Proposals. That is, these are the things that I am currently working on. Then again, Submitted Proposals can be edited before the deadline and re-submitted for Semester Solicitations. So maybe only list proposals that can be modified.
• Proposals Tab

  • Added a bunch of proposals to see how this looks when viewing proposals (either in the 2-D layout of cards or the 1-D column of cards when viewing a selected proposal). I think this will work as long as we are able to use filters to keep the number of proposals down to a reasonable number.

  • Basic Information. Cleaned up the "Changes Pending" feedback. Works well. Still cannot leave to another section without loosing my edits (if I do not click Save first), but okay.

  • Scientific Justification. Known issues with persistence; otherwise okay.
  • Allocation Request. Known issues with persistence; otherwise okay. Layout seems reasonable. This will probably evolve as we include details so we probably do not want to fine tune this at this stage. But since each Allocation Request has only one Facility we might want to include the Facility when showing the list of Allocation Requests.

Consensus Feedback

• Really nice overall
• Before the user is logged in the open solicitations are not shown.  During the sprint review this was demonstrated to be a 401 error.
  •   STT-591 - Getting issue details... STATUS
• Want to discuss the overall navigation (like the top w/ icons, lower ones are confusing)
  • Try to isolate functional roles using UX
• Consistent & Persistant Filtering
• Changes pending is not working correctly.  At least one of us didn't notice the changes pending notification.
  •   STT-593 - Getting issue details... STATUS
• Note: Track OS and Browser 
• Note: Need to do the only authors can edit a proposal story at some point. 
  • STT-592 - Getting issue details... STATUS
• Is delete supposed to work?
• Edit button on detailed view took a while to find, 

•  Jeff:
  • For the solicitation I am not sure we want to display capabilities (there may be too many), I suspect we want to display the facilities for each solicitation though (maybe the capabilities as a redirect?)
  • What is the purpose of having the proposals section under the home page, I agree with Dana that this is confusing.
  • I think there is a question of if we want to be able to select the role we are logged in as?
  • Filter should persist when going to a detail view.
• Dana:

o Initial View
------------

- Overall the interface is very clean. Easy to read, easy to
navigate, and fast.

- Before login I cannot view the Solicitations.

- Maybe

"NRAO + GBO Telescope Time" --> "NRAO/GBO Telescope Time"
"Greenbank Observatory (GBT)" --> "Green Bank Telescope (GBT)"

and add:

"High Sensitivity Array (HSA)"
"Global Millimeter VLBI Array (GMVA)".

- The purpose of JWT at the top right is not clear. If I click
on it nothing happens.

o Login as SallyScientist
-----------------------

- Once I login I can view the Solicitations only after I reload the
page.

- On Home there are two buttons to create a proposal: one at the top
and the other under the "test solicitation". I was expecting the
latter to have already selected "test solicitation" once the proposal
was created.

- If I click on "View Past Awarded Proposals" I should only see those
proposals that were awarded time (no draft proposals). I realize
that this concept is probably not yet in the system.

- There are two ways to view Proposals. One is by clicking the
Proposal tab next to Home (where one can filter on the proposal), and
the other is by clicking the My Proposals tab next to Open
Solicitations. I can see the value of different displays of this
information but the functionality is a bit confusing. If I edit the
Proposal under My Proposal I am taken to the Proposal tab.

- Proposal View Mode

Maybe reduce the size of the left section that lists the proposals.

If I click on View under Scientific Justification I am placed back on
the Home page. I am not able to see the scientific justification
(which was already uploaded).

- Proposal Edit Mode

I cannot re-size the abstract window; seems like there is a little
widget for this but it does not work.

After I have clicked Save on the Basic Information page the there is a
temporary window that indicates the proposal is saved, but I still see
the blue bar at the top indicating "Changes Pending". This is
confusing since I have not made any changes yet.

If I edit the abstract on the Basic section and then move to the
scientific justification section without saving I loose the edit. It
would be useful to have some warning or indication of the edit status
and if information will be lost.

After I upload a scientific justification PDF, which works fine, if I
leave the proposal and come back I can no longer see (or can view) the
uploaded scientific justification. There is just a button "Select New
PDF".

o Login as TonyaTtamember
-----------------------

- Proposals Tab

Seems like the filter settings should persist. For example, if I select
SHOW->My, then go to the Home tab and back to the Proposal tab the filter
is set to SHOW->All.

What determines the placement of proposals cards?

Need to include a search to the filtering of proposals.

- Solicitation

Clicking on "Create a Solicitation" does not do anything.
Presumably not implemented yet.

If I click on "View Proposals" I was expect to see
only the proposals from the specified Solicitation but
all were listed.

- During the session multiple browser tabs were opened; not clear
when this happened and why.

Allie

1. This may not have real application but it might indicate an unwanted behavior
   1. I login with JohnDoe and edit test proposaleeeeeee
   2. While on that page, I login as Sally Scientist. I can now edit and save edits to this proposal. Even after a refresh
      
   3. I can do this with any other log in.
   4. The edits show up in test proposaleeeeeee when I login again as JohnDoe.
   5.  I can do the same to proposal  My test proposal 2 W4 HMXB, which only has JohnDoe as an author
      
   6. Sometimes I can see in the list of proposals test proposaleeeeeee in SallyScientists' list
   7. Returning to item (b), if I refresh, I see SallyScientist's proposals listed but I can still edit JohnDoe's
      1. This image shows John Doe's proposal but logged in as sally without refreshing first
         1. prefresh_as_Sally
      2. This image shows the screen after the refresh
         1. postrefresh_as_sally
   8. Finally, logging out leaves the information open (e.g., the edit proposal page) but I can no longer edit it, so that's good.
2. Again this may not be a practical issue, but I had multiple tabs open editing proposals as different users and it seemed to behavior well.
   1. Having the same person logged in editing the same proposal in different tabs creates problems. If I save an edit in one tab and do not refresh in the other, what ever I save in the "other" tab will overwrite the first. A refresh shows the first tab's update. This is a fair behavior perhaps.
   2. The same behavior happens when I am trying to edit the same proposal with two logged in accounts, which may be a problem. There is tandem editing in the current tool (to what ever degree it does or doesn't exhibit this problem).
3. Is it expected behavior that Tommy Ttamember and TonyaTtamember have different items in the "Review tab"? It looks like TonyaTtamember is a reviewer while Tommy Ttamember is admin?
   
4. It seems that there is a proposal listed as "My proposal" for Tommy Ttamember that has Tammy Ttamember as the primary author. Are these supposed to be the same person?
   1. If not, is Tommy ttamember exercising admin-powers to edit/create a proposal for Tammy?
   2. If Tommy ttamember has no intention of being on this proposal, should it show up under "my proposals"?
   3. Can users create  a proposal without being on it? That seems like a policy question, and I know the author portion has some work to do on it still.
5. I had the same experience as Dana with the abstract not saving upon navigation
   1. Happily though, I can't seem to accidentally navigate backwards using the mac track pad short cut.
6. On the landing page once i log in as anyone, I find it a bit unsightly to see duplicate tabs for navigation at the top.
7. Hitting the Review tab takes me back to home, not a separate interface for reviews and not even to the review tab at the bottom.
8. I can't seem to delete a proposal.

===========

The second set of tabs on the home page were only intended to get some "quick start" areas there - likely actions a person wants to take e.g. working on the most proposals edited or viewing the responses numbers for recently closed solicitations. We do need to do some UX work to really flesh out what should be here, but for now the tabs were removed so they are less confusing.

Multiple tabs: local storage is used to save the logged in user's JWT (identifies who is logged in). Local storage in a browser is organized by domain name and stores simple key/value pairs. Having multiple tabs open in one browser and logging in as different people won't work so well because the domain name is the same, so whatever tab logs in last overwrites who is logged in for all tabs.

The "JWT" button: This is for developers, so it doesn't look like does anything for users and it will go away when we have "real" authentication.

Clicking the "create proposal" button on the home page next to an open solicitation is going to have that solicitation already selected when the creation form opens - but that isn't hooked up yet so it doesn't work. The assessment of what should happen was correct - it just isn't implemented yet.  Perhaps we make that a story so it doesn't get lost. The same is true for clicking "view proposal" on a solicitation card - that is also not hooked up yet.

Switching between sections of proposal editing does lose the changes on that page without warning. We should make a story to address that. 

the scientific justification pdf upload is set up in the UI, but isn't set up in the backend, so saving doesn't actually work right now. We have stories for this already.

Filtering of proposal cards is handled by the back end, so any search or sorting will need to happen there as well in case we need to introduce pagination (which we will at some point). We will need stories for this.

Filters do not persist, but should. This is all front end work and we should make a story for it. 

Anyone with a role of TTAT member can see all proposals, but the "my" filter should still work to restrict what is shown. Because authorization is fake, we have a different list of users in the frontend than the backend, so sometimes things look funny. We can fix this or ignore it until we get to more default test data or real authorization.