TTA Tools Sprint Feedback Page

Allie: (Firefox, redhat)

• My expectations are
  • A realistic-looking solicitation can have a Real VLA or GBT proposal. The test solicitation is no good for testing?
  • In a Real VLA proposal, I can see the TOM, the ScienceTargetList, and the OS.
    • The capability request can update the TOM, the OS, and STL.
    • Updates to the TOM do not affect the OS.
    • Updates to the TOM should affect the STL.
    • I can edit the OS directly.
  • In a GBT Spectral Line,
    • a more detailed capability request now exists
    • can save a capability request but there is no TOM/STL/OS generated yet.
• Home page
  
  • Clicking on "create proposal" on a solicitation directs to the new proposal page as expected. I have to then specify what solicitation I want again on this page. It would be nice if it auto filled this if I'm navigating from the solicitation on the home screen.
  • delete the trailing quote+period on the Global Millimeter VLBI Array (GMVA)".  line (sprint 24 comment)
• Trying to edit an already created proposal
  • Home → My Proposals Card, blue edit button once I've found the proposal → edit mode activated
    • Difficulty in finding proposal but easy once I do
  • Home → Open Solicitations Card → View Proposals button → click my proposal card → doesn't take me to the proposal. it just takes me to a list view of all the proposals and my proposal is expanded into a new card. The expanded card as the grey edit button → edit mode activated
    • Many screens and scrolling required. The edit button is subtle here.
    • In a previous version, the expanded card would show up next to a list of all the filtered or unfiltered proposals. It tries to do that briefly but then gets shunted to the bottom of the page in my browser.
  • Home → My Proposals Card → View All Proposals Link → click my proposal card → doesn't take me to the proposal. it just takes me to a list view of all the proposals and my proposal is expanded into a new card. The expanded card as the grey edit button → edit mode activated
    • Same issues as previous path.
• Capability Request for a realistic looking solicitation
  
  • Specifications
    • The + button for field source almost looks like it is for the spectral spec instead of adding a field source. Some space between the two might help. Same is true for the + for spectral spec and performance
  • Spectral Spec
    • The units of bandwidth and spectral resolution are wrong
  • Field Source
    • Trying to specify negative values for FOV, Parallax, etc does throw an error once I save.
    • A + in the radial velocity also throws the error "this.answer is null"
    • Adding a new field source but not filling it in throws the same error.
      • How do I delete a field source or a spectral spec?
    • When I collapse the capability request and expand it later, there is a truncation of the wording on any of the check boxes (e.g., coordinate system, epoch) that are checked.
    • I can't save with the null errors and so my changes don't persist if I collapse the capability but the checked boxes do persist? This is expected?
  • Unclear what delete button deletes what. Which one deletes the capability request vs the entire allocation request when I have them expanded?
  • In a GBT proposal for TommyttaMember, I've filled in all the fields; it is returning a null error but not highlighting any of the fields. I did not have this experience when I was in the SallyScientist proposal.
    • I tried a new proposal and it worked this time. I'm not sure why it didn't work before. I was trying to see what would break it at first and I got the null. I changed it all to "good" inputs and was still getting the null error. I fresh allocation request rectified this.
  • VLA Capability
    • In capabilities tab, if I hit save, I believe that updates the TOM, ScienceTargetList.
    • In the Target overrides matrix, do I need to hit save to update the override or does it do it automatically? - I think it's the save button but at first I thought it was the save button from the capability request.
    • I was unsure about how these are saved/updated, so it might also confuse a user, leading them to update or not update inadvertently.
    • When is the ScienceTargetList generated/updated - only when I hit save?  when I edit the TOM?
      • No system message is generated when I hit save on the TOM.
      • My edits to the TOM do not seem to be propagating to the ScienceTargetList. E.g., deselecting a source or changing the RMS sensitivity.
    • Is the band name that I specify in the capability request only in the TOM?
      
      • Should it eventually be in the ScienceTargetList and OS?
    • The source name isn't in the ScienceTargetList. I think it should be.
    • OS
      • When I add a scan, how does it decide how to populate the data? It seems like it's just the first ScienceTarget being filled in and being put at the bottom.
      • It would be nice to highlight this scan as being a change pending, as the scan lists can get really long and it might not be clear that this was the scan added.

Dana: (Firefox, Linux)

• Solicitations.

Allie: (Firefox, redhat)

• Allocation Requests
  • Creating a second Allocation Request works. At some point though, the ordering of the Allocation Request tabs change. It's happened a couple of times where Allocation Request and Allocation Request 2 will flip their order on the top bar. Spooky. I think it's putting whatever tab I'm currently working on first instead of just leaving the order alone.
  • Capability Request (the tab is called Capability though?)
    
    • When the specification first loads, I can see all the fields but if I click on a particular parameter, it gives a filtered view. Performance doesn't currently have more fields, so I wasn't sure what to do there. It was a bit unclear how to navigate the RMSSentitivty/performance/spatial/spectral filters from there then. I think you can hit enter, which brings up the macro list of parameters (or cycles through the parameters) or you can click again on a parameter to return to the macro list.
    • The save button does save but it also redirects to the TOM right away, regardless if I was done entering in all the fields. For example, I put in one field source and no spectral spec, and it redirected me. As someone who hits the save button as a soothing mechanism/ thought-clearing instinct, this is a bit disruptive. Happily the information in the parameters persists as I navigate around the capability tab. They do not propagate to the observation specification unless I hit the save button.
      • If I enter a parameter in the Capability, go to the Observation Specification, and back without hitting save, the newly entered parameter does persist in the Capability even though I did not save it. I think that's a good thing.
    • the spectral specification
      • the Center frequency field has a helpful tip suggesting I enter in an RA. Bandwidth similarly suggests that a Declination is needed.
    • Should the side bar instead be named performance, calibration, field source, spectral (spec)? RMS is a performance parameter. The other performance parameters are missing.
    • The calibration parameters are missing.
    • (bookkeeping) the Advance Button still exists
    • I can delete a Capability Request. It seemingly still exists in the Observation Specification though and I'm not sure how to get rid of it.
    • If I act like I'm going to delete a Capability Request but then hit cancel when it prompts me to delete it, sometimes a weird error shows up at the top of the screen in red saying that that item can't be found. It's hard to replicate but I have seen it 3 ish times.
  • Observation Specification
    • I think the filters are working as I expect.
    • If I hold down shift to try to multi select, it opens a new window of firefox instead. Crtl causes tabs with the title of "javascript:void(0)" to appeared in my browser. Maybe it's a linux problem?
    • Will there be a way to clear all filters?
    • I can Save the Observation Specification with my changes. It needs a big notice telling the user that the capability request is now invalid though.
    • I'm able to generate multiple Observation Specifications (see TOM comment). I don't have an OS with a lot of scans, but I think it has a nice layout.
      • Since there can be multiple Observation Specifications, should the name in the tab be "Observation Specification" still?
    • The name I put into the spectral spec doesn't seem to show up anywhere in the Observation Specification. It might be good to think more about why we have this field and its purpose, as the observation specification should probably display the actual names of the bands, as it currently does.
    • (bookkeeping) there are two save buttons: the one at the bottom of the observation spec and the one in the edit mode of a scan.
    • Adding a second Capability Request (and saving) did not immediately add it to the Observation Specification. I had to click around a bit and then it showed up finally. I'm having trouble replicating this behavior though.
    • I like that when I'm editing a Observation Specification, it says changing pending for that one and not all of them.
    • I can delete all the scans in an Observation Specification but I cannot delete the OS itself.
    • The column headings on the scan list are not lining up properly.
  • TOM
    • Clicking the button generates a new Observation Specification in addition to the one(s) already in the Observation Specification tab. I know the TOM isn't user facing but thought I'd note it.
    • Once a Observation Specification exists, how do you update it from the Capability Request. Clicking the Generate Observation Specification button in this tab will create a second one that reflects the state of the capability request. (I think this is in Sprint 28: STT-682)

Dana (Firefox; Fedora):

• Allocation Request
  • Capabilities
    • I think RMSSensitivity should be under Performance.
    • I would add "Calibration" to the list (even if just a place holder now).
    • I would order these: Spatial, Spectral, Performance, and Calibration.  This is more in line with how a scientist would think about the flow of information. 
    • After creating a VLA Continuum Capability I tried to create a GBT Spectral Line Capability within the same Allocation Request.  I should not be able to do this since an AR can only have one Facility.  But I was able to do this initially until I saved the Capability Request and got an internal server error.
    • When I save a Capability I am sent to the Target Overrides tab which is a bit odd but okay for now.
  • Target Override
    • Little confused by this tab but I think we discussed this at one of the meetings.
    • Each time I click the "Generate Observation Specification" Button I can see a new Observation Specification, even if I have not changed the Capability Request. 
  • Observation Specification
    • Overall this looks pretty good. 
    • I could not find a way to delete an entire Observation Specification.

Dana:

• Allocation Requests
  • Not sure of the purpose of Target Overrides.
  • Only one Field Source and one Spectral Spec is saved.
  • Advanced button does not seem to do anything.

Jeff:

• Why are there no Specifications under the VLA Continuum (is this a configuration issue for the solicitation or something else)?

Dana:

• Home
  • I can now see the Solicitations without logging in first.
• Allocation Request

  • When in edit mode, if I click the Allocation Request tab (on left) I see "Allocation Request +Add". My intuition was that I had to click the "+Add" to create an Allocation Request, but if I do this it creates a second Allocation Request. What I should have done was to click "Allocation Request" to start filling in the first one.

  • Not sure if there was suppose to be any way to input information for the VLA Continuum Capability.
  • I still cannot save an Allocation Request, but I can delete one.
  • When in edit mode, if I cancel (click the "x" in the top right-hand corner), I am brought back to the view with the 2-D layout of cards. I would have expected to see the view with the 1-D column of cards on the left with the proposal that I just cancelled on the right.

Allie:

• Home page
  • delete the trailing quote+period on the Global Millimeter VLBI Array (GMVA)".  line
  • is it necessary to have two different create proposal buttons? For example, would the button next to the open solicitations automatically have that solicitation checked?
  • How is the priority set for the list of proposals in "My Proposals"? The newest created proposal is not at the top of the list as I would expect.
  • TonyattaMember and TommyttaMember have different home pages. Is this expected behavior because they have different profiles?
• Editing a Proposal
  • Allocation Request
    • When I add a Capability to an Allocation Request, the changes pending bar behaves as expected: the bar does appear until I make changes. It does not go away when I hit Save though. The save button doesn't appear to work. Maybe that isn't implemented yet.
    • When I make multiple Allocation Requests and then try to delete one, it sometimes deletes all of them instead. I'm having trouble consistently replicating this behavior but it did happen at least 4 times.
    • Is this expected behavior?
      • Create Allocation Request and Allocation Request 2
      • Delete Allocation Request
      • Add an Allocation Request makes a new allocation request with the name of "Allocation Request 2" such that now there are two Allocation Request 2s.
      • When adding more Allocation Requests (AR 3, AR4), the tabs reorder themselves as
        • AR3, AR4, AR2, AR2
    • Capabilities do not persist when switching between allocation requests (maybe the aforementioned save issue?).
    • Cannot rename the AR or the Capability
  • Clicking between "Basic Information", "Scientific Justification", "Allocation Request" very briefly changes the wording at the top left from "Edit Proposal" to "New Proposal" and back again to "Edit Proposal".
  • When clicking back to "Basic Information" from "Scientific Justification" or "Allocation Request", the check box with the "test solicitation" sometimes briefly displays the words "[object Object] " instead.

Dana:

• Home Tab
  • Looks better. Need to think what we really want here. If we list Open Solicitation maybe we should list Draft Proposals instead of My Proposals. That is, these are the things that I am currently working on. Then again, Submitted Proposals can be edited before the deadline and re-submitted for Semester Solicitations. So maybe only list proposals that can be modified.
• Proposals Tab

  • Added a bunch of proposals to see how this looks when viewing proposals (either in the 2-D layout of cards or the 1-D column of cards when viewing a selected proposal). I think this will work as long as we are able to use filters to keep the number of proposals down to a reasonable number.

  • Basic Information. Cleaned up the "Changes Pending" feedback. Works well. Still cannot leave to another section without loosing my edits (if I do not click Save first), but okay.

  • Scientific Justification. Known issues with persistence; otherwise okay.
  • Allocation Request. Known issues with persistence; otherwise okay. Layout seems reasonable. This will probably evolve as we include details so we probably do not want to fine tune this at this stage. But since each Allocation Request has only one Facility we might want to include the Facility when showing the list of Allocation Requests.

Consensus Feedback

• Really nice overall
• Before the user is logged in the open solicitations are not shown.  During the sprint review this was demonstrated to be a 401 error.
  •   STT-591 - Getting issue details... STATUS
• Want to discuss the overall navigation (like the top w/ icons, lower ones are confusing)
  • Try to isolate functional roles using UX
• Consistent & Persistant Filtering
• Changes pending is not working correctly.  At least one of us didn't notice the changes pending notification.
  •   STT-593 - Getting issue details... STATUS
• Note: Track OS and Browser 
• Note: Need to do the only authors can edit a proposal story at some point. 
  • STT-592 - Getting issue details... STATUS
• Is delete supposed to work?
• Edit button on detailed view took a while to find, 

•  Jeff:
  • For the solicitation I am not sure we want to display capabilities (there may be too many), I suspect we want to display the facilities for each solicitation though (maybe the capabilities as a redirect?)
  • What is the purpose of having the proposals section under the home page, I agree with Dana that this is confusing.
  • I think there is a question of if we want to be able to select the role we are logged in as?
  • Filter should persist when going to a detail view.
• Dana:

o Initial View
------------

- Overall the interface is very clean. Easy to read, easy to
navigate, and fast.

- Before login I cannot view the Solicitations.

- Maybe

"NRAO + GBO Telescope Time" --> "NRAO/GBO Telescope Time"
"Greenbank Observatory (GBT)" --> "Green Bank Telescope (GBT)"

and add:

"High Sensitivity Array (HSA)"
"Global Millimeter VLBI Array (GMVA)".

- The purpose of JWT at the top right is not clear. If I click
on it nothing happens.

o Login as SallyScientist
-----------------------

- Once I login I can view the Solicitations only after I reload the
page.

- On Home there are two buttons to create a proposal: one at the top
and the other under the "test solicitation". I was expecting the
latter to have already selected "test solicitation" once the proposal
was created.

- If I click on "View Past Awarded Proposals" I should only see those
proposals that were awarded time (no draft proposals). I realize
that this concept is probably not yet in the system.

- There are two ways to view Proposals. One is by clicking the
Proposal tab next to Home (where one can filter on the proposal), and
the other is by clicking the My Proposals tab next to Open
Solicitations. I can see the value of different displays of this
information but the functionality is a bit confusing. If I edit the
Proposal under My Proposal I am taken to the Proposal tab.

- Proposal View Mode

Maybe reduce the size of the left section that lists the proposals.

If I click on View under Scientific Justification I am placed back on
the Home page. I am not able to see the scientific justification
(which was already uploaded).

- Proposal Edit Mode

I cannot re-size the abstract window; seems like there is a little
widget for this but it does not work.

After I have clicked Save on the Basic Information page the there is a
temporary window that indicates the proposal is saved, but I still see
the blue bar at the top indicating "Changes Pending". This is
confusing since I have not made any changes yet.

If I edit the abstract on the Basic section and then move to the
scientific justification section without saving I loose the edit. It
would be useful to have some warning or indication of the edit status
and if information will be lost.

After I upload a scientific justification PDF, which works fine, if I
leave the proposal and come back I can no longer see (or can view) the
uploaded scientific justification. There is just a button "Select New
PDF".

o Login as TonyaTtamember
-----------------------

- Proposals Tab

Seems like the filter settings should persist. For example, if I select
SHOW->My, then go to the Home tab and back to the Proposal tab the filter
is set to SHOW->All.

What determines the placement of proposals cards?

Need to include a search to the filtering of proposals.

- Solicitation

Clicking on "Create a Solicitation" does not do anything.
Presumably not implemented yet.

If I click on "View Proposals" I was expect to see
only the proposals from the specified Solicitation but
all were listed.

- During the session multiple browser tabs were opened; not clear
when this happened and why.

Allie

1. This may not have real application but it might indicate an unwanted behavior
   1. I login with JohnDoe and edit test proposaleeeeeee
   2. While on that page, I login as Sally Scientist. I can now edit and save edits to this proposal. Even after a refresh
      
   3. I can do this with any other log in.
   4. The edits show up in test proposaleeeeeee when I login again as JohnDoe.
   5.  I can do the same to proposal  My test proposal 2 W4 HMXB, which only has JohnDoe as an author
      
   6. Sometimes I can see in the list of proposals test proposaleeeeeee in SallyScientists' list
   7. Returning to item (b), if I refresh, I see SallyScientist's proposals listed but I can still edit JohnDoe's
      1. This image shows John Doe's proposal but logged in as sally without refreshing first
         1. prefresh_as_Sally
      2. This image shows the screen after the refresh
         1. postrefresh_as_sally
   8. Finally, logging out leaves the information open (e.g., the edit proposal page) but I can no longer edit it, so that's good.
2. Again this may not be a practical issue, but I had multiple tabs open editing proposals as different users and it seemed to behavior well.
   1. Having the same person logged in editing the same proposal in different tabs creates problems. If I save an edit in one tab and do not refresh in the other, what ever I save in the "other" tab will overwrite the first. A refresh shows the first tab's update. This is a fair behavior perhaps.
   2. The same behavior happens when I am trying to edit the same proposal with two logged in accounts, which may be a problem. There is tandem editing in the current tool (to what ever degree it does or doesn't exhibit this problem).
3. Is it expected behavior that Tommy Ttamember and TonyaTtamember have different items in the "Review tab"? It looks like TonyaTtamember is a reviewer while Tommy Ttamember is admin?
   
4. It seems that there is a proposal listed as "My proposal" for Tommy Ttamember that has Tammy Ttamember as the primary author. Are these supposed to be the same person?
   1. If not, is Tommy ttamember exercising admin-powers to edit/create a proposal for Tammy?
   2. If Tommy ttamember has no intention of being on this proposal, should it show up under "my proposals"?
   3. Can users create  a proposal without being on it? That seems like a policy question, and I know the author portion has some work to do on it still.
5. I had the same experience as Dana with the abstract not saving upon navigation
   1. Happily though, I can't seem to accidentally navigate backwards using the mac track pad short cut.
6. On the landing page once i log in as anyone, I find it a bit unsightly to see duplicate tabs for navigation at the top.
7. Hitting the Review tab takes me back to home, not a separate interface for reviews and not even to the review tab at the bottom.
8. I can't seem to delete a proposal.

===========

The second set of tabs on the home page were only intended to get some "quick start" areas there - likely actions a person wants to take e.g. working on the most proposals edited or viewing the responses numbers for recently closed solicitations. We do need to do some UX work to really flesh out what should be here, but for now the tabs were removed so they are less confusing.

Multiple tabs: local storage is used to save the logged in user's JWT (identifies who is logged in). Local storage in a browser is organized by domain name and stores simple key/value pairs. Having multiple tabs open in one browser and logging in as different people won't work so well because the domain name is the same, so whatever tab logs in last overwrites who is logged in for all tabs.

The "JWT" button: This is for developers, so it doesn't look like does anything for users and it will go away when we have "real" authentication.

Clicking the "create proposal" button on the home page next to an open solicitation is going to have that solicitation already selected when the creation form opens - but that isn't hooked up yet so it doesn't work. The assessment of what should happen was correct - it just isn't implemented yet.  Perhaps we make that a story so it doesn't get lost. The same is true for clicking "view proposal" on a solicitation card - that is also not hooked up yet.

Switching between sections of proposal editing does lose the changes on that page without warning. We should make a story to address that. 

the scientific justification pdf upload is set up in the UI, but isn't set up in the backend, so saving doesn't actually work right now. We have stories for this already.

Filtering of proposal cards is handled by the back end, so any search or sorting will need to happen there as well in case we need to introduce pagination (which we will at some point). We will need stories for this.

Filters do not persist, but should. This is all front end work and we should make a story for it. 

Anyone with a role of TTAT member can see all proposals, but the "my" filter should still work to restrict what is shown. Because authorization is fake, we have a different list of users in the frontend than the backend, so sometimes things look funny. We can fix this or ignore it until we get to more default test data or real authorization.