Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

PPRs - Review Type Assignments

DescriptionJIRAImplementedLast WorkingTestedStatus

SRP Chair

  • can see a "matrix" of Reviewers in their panel, their Conflict States, the Review States of their ISRs
  • can assign Review Type per ISR
    • Only 1 Primary, 1 Secondary, * Tertiary, * None per Proposal
    • Default is None
    • Can change Review Types unless ISR is Finalized
  • Cannot be able to assign types of Conflicted reviewers
  • Cannot change Review Type of External Reviewer
  • External Reviewer's name is redacted but can see the Review Type and Review State for the external ISR



Sprint 46/47

Sprint 59


Sprint 59

Status
subtleTrue
colourBlue
colorgreen
titleWorking

  • can see a "matrix" of Reviewers in their panel and their Conflict State
  • Only one Primary and one Secondary can be saved to a proposal.
  • Any number of None or Teritary can be saved to a proposal.
  • Cannot assign Review Types to a conflicted reviewer
  • Cannot change Review Type of External Reviewer
  • External Reviewer's name is redacted but can see the Review Type and Review State for the external ISR

TTA Member

  • Can change any Review Type even if the Review State is Finalized until Consensus starts
  • Can change the Review Type of external ISRs until Consensus of the hosting panel begins



Sprint 45/47Sprint 59Sprint 59

Status
subtleTrue
colourBlue
colorgreen
titleWorking

  • Can change RT of external ISR as long as Consensus for the hosting panel has not started
  • Can change RT of any ISR even in Finalized State until the start of Consensus

PPRs - ISRs

DescriptionJIRAImplementedLast WorkingTestedStatus
  • SRP Reviewer
    • See list of proposals (after conflict certification)
    • Review Type is displayed
      • Default is None; otherwise P,S,T
    • Review State is displayed
      • default is Blank; otherwise Saved, Completed, Finalized, Closed
    • Conflict State is displayed
      • Conflict/Available
    • If not Conflicted, have an ISR in which to enter comments and a score and see the proposal
      • can Save (Review State → Saved) per ISR
        • validate if score not equal to 0; otherwise it cannot save
        • does not validate comments
      • can Complete (Review State → Completed) per ISR
      • can Finalize (bulk action) if any ISRs with Review not equal to None are not Closed or Finalized
    • If Conflicted, only see title, abstract, proposal ID and cannot enter any information
  • All comments and scores are saved (though not propagated to consensus; see later)
  • Normalized Individual Scores are calculated on Finalize
  • Edge cases to test:
    • If an external proposal is added after reviewer has finalized, they should be able to review and finalize that one proposal (finalize is still bulk in theory)
    • If consensus has started for their panel, the Finalized Normalized Individual Score in that panel may be inconsistent with their new Normalized Individual Score (since it has the extra proposal). This is acceptable.


Jira
serverDMS JIRA
columnIdsissuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution
columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
serverIdeb2e750b-a83a-387e-8345-36eee8a98f01
keySTT-877

Jira
serverDMS JIRA
columnIdsissuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution
columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
serverIdeb2e750b-a83a-387e-8345-36eee8a98f01
keySTT-878

Jira
serverDMS JIRA
columnIdsissuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution
columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
serverIdeb2e750b-a83a-387e-8345-36eee8a98f01
keySTT-873

Jira
serverDMS JIRA
columnIdsissuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution
columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
serverIdeb2e750b-a83a-387e-8345-36eee8a98f01
keySTT-879


Sprint 46, 47SprintSprint

Status
subtleTrue
colourBlue
colorgreen
titleWorking

  • SRP Reviewer
    • See list of proposals (after conflict certification)
    • Review Type is displayed
      • Default is None; otherwise P,S,T
    • Review State is displayed
      • default is Blank; otherwise Saved, Completed, Finalized, Closed
    • If not Conflicted, have an ISR in which to enter comments and a score and see the proposal
      • can Save (Review State → Saved) per ISR
        • validate if score not equal to 0; otherwise it cannot save
        • does not validate comments
    • All comments and scores are saved (though not propagated to consensus; see later)

Status
subtleTrue
colourYellow
colorgreen
titleTesting

  • can Complete (Review State → Completed) per ISR
  • can Finalize (bulk action) if any ISRs with Review not equal to None are not Closed or Finalized
  • Can a user state change from Completed to Saved in UI?
  • If Conflicted, only see title, abstract, proposal ID and cannot enter any information
  • Conflict State is displayed
    • Conflict/Available

Status
subtleTrue
colourRed
colorgreen
titleto fix

  • Conflict state not preventing visibility to proposals when appropriate

External Reviewer

  • External Reviewer is someone who is on any one panel associated with the Solicitation in question
  • An external reviewer can be assigned an external ISR for any proposal as long as the Panel associated with that proposal has not started Consensus
  • External Reviewers do not have to declare conflicts on external ISRs. When assigned, the conflict state is automatically set to Available
  • External Reviewers can see the external ISR in their list of ISRs.
  • ER can provide comments, scores, save, complete, and finalize their external ISRs
  • ER do not have access to the Consensus UI or any responsibility at Consensus for the panel associated with the external ISR.

Jira
serverDMS JIRA
columnIdsissuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution
columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
serverIdeb2e750b-a83a-387e-8345-36eee8a98f01
keySTT-1395

Jira
serverDMS JIRA
columnIdsissuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution
columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
serverIdeb2e750b-a83a-387e-8345-36eee8a98f01
keySTT-1328




Status
subtleTrue
colourBlue
colorgreen
titleWorking

  • External Reviewer is someone who is on any one panel associated with the Solicitation in question
  • An external reviewer can be assigned an external ISR for any proposal as long as the Panel associated with that proposal has not started Consensus
  • External Reviewers do not have to declare conflicts on external ISRs. When assigned, the conflict state is automatically set to Available
  • ER do not have access to the Consensus UI or any responsibility at Consensus for the panel associated with the external ISR.

Status
subtleTrue
colourRed
colorgreen
titleto fix

  • External Reviewers can see the external ISR in their list of ISRs.
  • ER can provide comments, scores, save, complete, and finalize their external ISRs

Import/Export ISRs

  • a CSV file is expected but it can use as a delimiter any of the following:
    • , ; | tab
  • putting double quotes around the comment will keep the commas within the comment safe
  • if reviews exist when asked to export, it will export the reviews
  • cannot upload a file with any blank fields (fails and warning issued)
  • if a user changes the name of the reviewer within the file, it gives an error
  • protects against Bobby Drop Tables
  • on a successfull upload, the Review State of the ISR will changed to Saved (not sure what it does for completed or a re-upload)







TTA Member

  • can change Review State to Closed
    • Auto changes Review Type to None
  • If a TTA member Finalizes a SRP member's ISRs (for the reviewer), it will finalize the ISRs that have a valid comment and score (Review State of Saved, Completed) and Review Type not equal to None. If a comment+score is not valid, regardless of the Review Type, it will Close the ISR (unsure if it still ignores review types of None)
  • can change Review Type until Consensus is initated for the SRP member's panel.
  • can change Review State utnil Consensus is initiated for the SRP member's panel.

Jira
serverDMS JIRA
columnIdsissuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution
columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
serverIdeb2e750b-a83a-387e-8345-36eee8a98f01
keySTT-1039




Status
subtleTrue
colourBlue
colorgreen
titleto test

  • When TTA member uses Finalize, as a bulk action for all ISRs for that reviewer
    • Review Types of Primary, Secondary, Tertiary but have Review State of Blank are set to Close
    • Review Type of None is ignored, regardless of Review State
    • Review Types of P,S,T that have Review States in (Saved, Completed) are transitioned to Finalized
  • A separate Close functionality will be per ISR

Adding exernal reviewers as TTA member

  • If an external reviewer is added, the Conflict state is automatically Available.





...