Page History

• Date: //date
• Time: 9:00 ET
• Location: nraozoom04 
• Sprint Calendar

Attendance:

• Jeff Kern
• Dana Balser
• Mark Whitehead 
• Allison Costa
• Mark Ferguson 

Agenda:

• Supplemental Diagrams in Confluence now for reference:
  • https://open-confluence.nrao.edu/x/WwCtBg

• Is this actually automatic or does the TTA member initiate this?

  Jira
  server DMS JIRA columnIds issuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId eb2e750b-a83a-387e-8345-36eee8a98f01 key STT-904

• Currently, do we use the Review State of Finalized to prevent edits to ISRs?

  Jira
  server DMS JIRA columnIds issuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId eb2e750b-a83a-387e-8345-36eee8a98f01 key STT-879

  • (How) Do we prevent modification of ISRs with Review Type = None currently?
  • Suggestion: At initiation of Consensus sub-phase, all ISRs are immutable for the SRP member

• What do we mean by "Reviews" in the UI currently?
  
  • Proposal Process
  • "Review Process" 

• Here is  is a link to some GBO DSS documentation to clarify the distinction between DSS and PHT.

• TTA member can modify ISRs (Review State, comments and score) up until Consensus starts for a panel
  • Note, this means they cannot Close an ISR once Consensus starts.
• TTA member can change Review Types until the NLR is generated
• TTA member can modify Consensus reviews (Review State, comments, score) up until Disposition Letters are sent.

Image Added

Recall:

• Finalizing ISRs is a per reviewer action. It changes the Review State to Finalized for ISRs with Review type of  Primary, Secondary, or Tertiary. If the Review Type is None, the Review State does not change. The implication is that a Review Type = None usually does not have a Review State of Finalized. (Discussion for later if the TTA member intervenes with a manual change.)
  • To Finalize, the ISRs with Review Type of Primary, Secondary, Tertiary must be in the Saved/Completed state.
  • If the Review Type is None, the Review State does not change.
• Finalizing calculates the Normalized Individual Score (NIS) and prevents the SRP member from editing the ISRs. using any ISR with a Review State of Finalized and a Review Type of Primary, Secondary, or Tertiary. Note, this condition is different that what the ticket explicitly stated 

  Jira
  server DMS JIRA columnIds issuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId eb2e750b-a83a-387e-8345-36eee8a98f01 key STT-1166

  and 

  Jira
  server DMS JIRA columnIds issuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId eb2e750b-a83a-387e-8345-36eee8a98f01 key STT-879

  . This modified behavior is more useful though.
  
  • ISRs with review state of Finalized cannot be modified by SRP members.
  • There is currently nothing stopping an SRP member from editing ISRs that have a Review State other than Finalized.
• To start Consensus, all ISRs with Review Types of P,S,T must have Review States of Finalized.
• At the start of Consensus, the NIS per reviewer are copied into Finalized NIS.
• (Proposed) TTA member cannot change Review State after Consensus starts.

Use Case

A SRP member has Finalized their ISRs. It is prior to Consensus . They would like to make an edit.starting.

• If the Review Type is None, then the Review State can only be Blank/Saved/Completed/Closed.
  
  • (1) If the Review Type is not changed and the Review State is not Closed/Finalized, then they the SRP member are (as of Sprint 50) able to continue editing the review and save edits into perpetuity.
    • (1) Even though
    the comments
    • the comments won't go to Consensus, it is best to have a hard stop to their edits at some point.
      
    • Proposed Fix: Initiating Consensus should prevent edits by SRP members to any ISRs associated with that panel.
  • (2) If TTA member changes the Review Type to P, S, or T and Review State is not Closed/Finalized, then SRP member can modify their review. The Finalize button will trigger.
    • (2) The correct NIS's will propagate into Consensus and the TTA member cannot start Consensus until the SRP member finalizes (again).
      
  • If the Review State is changed from Closed, then 1 or 2 applies.
  • If the Review State is changed to Closed, then no further action is needed.
  • The TTA member should never change the Review State to Finalized per ISR in this case. It should always be done via the Finalize button, which acts on all ISRs per reviewer. Otherwise, the NIS won't be recalculated correctly.

• If the Review Type is P, S, or T, then the Review State is Finalized.
  • If a TTA member changes the Review State of Finalized to Blank/Saved/Completed and does not change the Review Type to None, Consensus cannot be initiated until the SRP member elects to Finalize their ISRs again: the SRP member MUST Finalize again for the system to allow Consensus to start. Note, it does not matter if the Review Type is changed between P, S, or T. The correct NIS's will propagate into Consensus and the TTA member cannot start Consensus until the SRP member finalizes (again; same as 2 above).
    
  • If a TTA member changes the Review Type between P, S, and T, no changes occur that affect ISRs, the NIS, or the ISR comments that go to Consensus. It only changes access to modify to Consensus Reviews.
  • If a TTA member changes the Review State to Blank/Saved/Completed and changes the Review Type to None:
    • (3) The previously calculated Normalized Individual Score NIS does not reflect this change as there is currently not an automatic recalculation of the NIS. Furthermore, the Finalize button will never trigger, so there is no way for the SRP member to force the recalculation.
    • They also will be able to edit it ISRs with Review Type of None into perpetuity (see 1 above).
    • (4) The TTA member could use the Finalize button for the SRP member, which would solve this issue.
      
      • Recall that if the TTA member uses the Finalize button for an SRP member:
        • all of their ISRs with Review Type of P,S, or T with review states of Blank → Closed
        • ISRs with Review Types of P, S, T and states of Saved/Completed → Finalized
        • ISRs with Review Types of None have no state change
          
        • ISRs with Review States of Finalized and Closed have no state change
          
        • Only ISRs with Review States of Finalized and Review Types of P, S, or T are used to calculate NIS.
          
      • So, the correct NIS would be calculated in this event.
  • If a TTA member changes the Review State to Closed, the Review Type is always forced to None. Further edits are prevented because of the Closed state .
    but the NIS is out of sync now:
    
    • See (3).
    • See (4)
    • The previously calculated Normalized Individual Score does not reflect this change as there is currently not an automatic recalculation of the NIS.
    • Furthermore, the Finalize button will never trigger, so there is no way for the SRP member to force the recalculation.
  • If a TTA member does not change the Review State of Finalized but changes the Review Type to None
    • Should there be a recalculation of the NIS?

      Jira
      server DMS JIRA columnIds issuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId eb2e750b-a83a-387e-8345-36eee8a98f01 key STT-1166

    • If so, see (3) and (4).

In in Consensus, an ISR review state, comments, and score cannot be modified by anyone, but a TTA member is able to modify the Review Type.

  At the start of Consensus, the NIS per reviewer is copied into Finalized NIS.

• Changes to the Review Type really should only determine the SRP member's ability to enter Consensus Comments.
  
• Weird edge caseEdge cases:
  • SRP member A for Panel 1 Finalizes finalizes their ISRs. Their Consensus Meeting starts . The for Panel 1.
  • For a good reason, the TTA member changes one of their Review Types to None which was previously a SRP member A's ISRs to Review Type = None, which previously had a Review Type = Secondary. The ISR Review State = equals Finalized and now the Review Type = None. This is not allowed normally and should not matter to the Consensus Review..
  • This change only means that SRP member A cannot enter or complete Consensus Comments for that proposal. This change cannot affect the NIS or FNIS or any other score or available of comments because all of those objects are defined at the start of Consensus.
  • Then, SRP member A is assigned an external ISR.
    • The ISR with a Review State of Finalized and a Review Type of None will be excluded from the calculation of the new NIS. Their new NIS will be discrepant from the NIS shown in Panel A
    If the SRP member is then assigned an external review from Panel 2. Should it matter to calculating the NIS that they now have a Review State = Finalized & Review Type = None for an ISR in Panel 1?
    • The only ISRs with Review State of Finalized go into calculating the Normalized Individual Score (NIS).

Open Actions: