Page History

• Date: //date
• Time: 9:00 ET
• Location: nraozoom04 
• Sprint Calendar

Attendance:

• Jeff Kern
• Dana Balser
• Mark Whitehead 
• Allison Costa
• Mark Ferguson 

Agenda:

• Supplemental Diagrams in Confluence now for reference:
  • https://open-confluence.nrao.edu/x/WwCtBg

• Is this actually automatic or does the TTA member initiate this?

  Jira
  server DMS JIRA columnIds issuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId eb2e750b-a83a-387e-8345-36eee8a98f01 key STT-904

• Currently, do we use the Review State of Finalized to prevent edits to ISRs?

  Jira
  server DMS JIRA columnIds issuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId eb2e750b-a83a-387e-8345-36eee8a98f01 key STT-879

  • (How) Do we prevent modification of ISRs with Review Type = None currently?
  • Suggestion: At initiation of Consensus sub-phase, all ISRs are immutable for the SRP member

• What do we mean by "Reviews" in the UI currently?
  
  • Proposal Process
  • "Review Process" 

• Here is a link to some GBO DSS documentation to clarify the distinction between DSS and PHT.

• TTA member can modify ISRs (Review State, comments and score) up until Consensus starts for a panel
• TTA member can change Review Types until the NLR is generated
• TTA member can modify Consensus reviews (Review State, comments, score) up until Disposition Letters are sent.

Recall:

• Finalizing ISRs is a per reviewer action. It changes the Review State to Finalized for ISRs with Review type of  Primary, Secondary, or Tertiary. If the Review Type is None, the Review State does not change. The implication is that a Review Type = None cannot usually does not have a Review State of Finalized. (Discussion for later if the TTA member intervenes with a manual change.)
  JiraserverDMS JIRAcolumnIdsissuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolutioncolumnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolutionserverIdeb2e750b-a83a-387e-8345-36eee8a98f01keySTT-1166
• To Finalize, the ISRs with Review Type of Primary, Secondary, Tertiary must be in the Saved/Completed state.
• Finalizing calculates the Normalized Individual Score (NIS) and prevents the SRP member from editing the ISRs. There is currently nothing stopping an SRP member from editing ISRs that have a Review State other than Finalized.
• To start Consensus, all ISRs with Review Types of P,S,T must have Review States of Finalized.
• At the start of Consensus, the NIS per reviewer are copied into Finalized NIS.
• (Proposed) TTA member cannot change Review State after Consensus starts.

Use Case

A SRP member has Finalized their ISRs. It is prior to Consensus. They would like to make an edit.

• If the Review Type is None, then the Review State can only be Blank/Saved/Completed/Closed.
  
  • (1) If the Review Type is not changed, then they are currently (as of Sprint 50) able to continue editing the review and save edits into perpetuity. Even though the comments won't go to Consensus, it is best to have a hard stop to their edits at some point.
    
    • Proposed Fix: Initiating Consensus should prevent edits by SRP members to any ISRs.
  • (2) If TTA member changes the Review Type to P, S, or T and Review State is not Closed, then SRP member can modify their review. The Finalize button will trigger. The correct NIS's will propagate into Consensus.
  • (3) If the Review State is changed to Closed, the Review Type is always forced to None and further edits are prevented.(4) If the Review State is changed from Closed, then 1 or 2 applies.

• If the Review Type is P, S, or T, then the Review State is Finalized.
  • If a TTA member changes Review State of Finalized to Blank/Saved/Completed and does not change to the Review Type to None, Consensus cannot be initiated until the SRP member elects to Finalize their ISRs again: the SRP member MUST Finalize again for the system to allow Consensus to start. Note, it does not matter if the Review Type is changed between P, S, or T. The correct NIS's will propagate into Consensus.
  • If a TTA member changes Review State to Blank/Saved/Completed and changes the Review Type to None:
    • The previously calculated Normalized Individual Score does not reflect this change as there is currently not an automatic recalculation of the NIS.
    • Furthermore, the Finalize button will never trigger, so there is no way for the SRP member to force the recalculation.
    • They also and they will be able to edit it into perpetuity . Even though the comments won't go to Consensus, it is best to have a hard stop to their edits.(see 1)
  • If a TTA member changes the Review State to Closed, the Review Type is always forced to None and further . Further edits are prevented .A TTA member is prevented from changing the Review Type to None if the Review State is Finalized.because of Closed state.
    
    • The previously calculated Normalized Individual Score does not reflect this change as there is currently not an automatic recalculation of the NIS.
    • Furthermore, the Finalize button will never trigger, so there is no way for the SRP member to force the recalculation.
  • If a TTA member does not change the Review State of Finalized but changes the Review to None
    • Should there be a recalculation of the NIS?

      Jira
      server DMS JIRA columnIds issuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId eb2e750b-a83a-387e-8345-36eee8a98f01 key STT-1166

If in Consensus, an ISR review state, comments, and score cannot be modified but a TTA member is able to modify the Review Type.

• The TTA member is prevented from Closing an ISR after Consensus starts.
• Changes to the Review Type really should only determine the SRP member's ability to enter Consensus Comments.
• Weird edge case:
  • SRP member for Panel 1 Finalizes ISRs. Their Consensus Meeting starts. The TTA member changes one of their Review Types to None which was previously a Secondary. The ISR Review State = Finalized and Review Type = None. This is not allowed normally and should not matter to the Consensus Review.
  • If the SRP member is then assigned an external review from Panel 2. Should it matter to calculating the NIS that they now have a Review State = Finalized & Review Type = None for an ISR in Panel 1?
    • The only ISRs with Review State of Finalized go into calculating the Normalized Individual Score (NIS).

Open Actions: