Page History

• Date: //date
• Time: 9:00 ET
• Location: nraozoom04 
• Sprint Calendar

Attendance:

• Jeff Kern
• Dana Balser
• Mark Whitehead 
• Allison Costa
• Mark Ferguson 

Agenda:

• Supplemental Diagrams in Confluence now for reference:
  • https://open-confluence.nrao.edu/x/WwCtBg

• Is this actually automatic or does the TTA member initiate this?

  Jira
  server DMS JIRA columnIds issuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId eb2e750b-a83a-387e-8345-36eee8a98f01 key STT-904

• Currently, do we use the Review State of Finalized to prevent edits to ISRs?

  Jira
  server DMS JIRA columnIds issuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId eb2e750b-a83a-387e-8345-36eee8a98f01 key STT-879

• What do we mean by "Reviews" in the UI currently?
  
  • Proposal Process
  • "Review Process" Image Removed 

• Here is a link to some GBO DSS documentation to clarify the distinction between DSS and PHT.

Recall:

• Finalizing ISRs is a per reviewer action. It changes the Review State to Finalized for ISRs with Review type of  Primary, Secondary, or Tertiary. If the Review Type is None, the Review State does not change.
• To Finalize, the ISRs with Review Type of Primary, Secondary, Tertiary must be in the Saved/Completed state.
• Finalizing calculates their Normalized Individual Score (NIS) and prevents the SRP member from editing the ISRs. (Assuming all ISRs are prevented from being edited when Finalized is hit, regardless of Review Type.)
• To start Consensus, all ISRs with Review Types of P,S,T must have Review States of Finalized.
• At the start of Consensus, the NIS per reviewer are copied into Finalized NIS.
• (Proposed) TTA member cannot change Review State after Consensus starts.

Use Case

A SRP member has Finalized their ISRs. It is before Consensus. They would like to make an edit.

• If the Review Type is None, then the Review State can only be Blank/Saved/Completed/Closed. A Review Type of None should NEVER be allowed to have a Review State of Finalized. 

  Jira
  server DMS JIRA columnIds issuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId eb2e750b-a83a-387e-8345-36eee8a98f01 key STT-1166

  
  
  • (1) If the Review Type is not changed, then the TTA member could (should) say "tough luck". If they elect to change the Review State to Blank/Saved/Completed, then the reviewer can edit+save. The Finalize button will never trigger and they will be able to edit it into perpetuity. Even though the comments won't go to Consensus, it is best to have a hard stop to their edits.
    • Fix: Initiating Consensus should prevent edits by SRP members to any ISRs.
  • (2) If TTA member changes the Review Type to P, S, or T and Review State is not Closed, then SRP member can modify their review. The Finalize button will trigger. The correct NIS's will propagate into Consensus.
  • If the Review State is changed to Closed, the Review Type is always forced to None and further edits are prevented.
  • If the Review State is changed from Closed, then 1 or 2 applies.

• If the Review Type is P, S, or T, then the Review State is Finalized.
  • If a TTA member changes Review Finalized to Blank/Saved/Completed and does not change to the Review Type to None, Consensus cannot be initiated until the SRP member elects to Finalize their ISRs again: the SRP member MUST Finalize again for the system to allow Consensus to start. The correct NIS's will propagate into Consensus.
  • If a TTA member changes Review State to Blank/Saved/Completed and changes the Review Type to None:
    • The Finalize button will never trigger and they will be able to edit it into perpetuity. Even though the comments won't go to Consensus, it is best to have a hard stop to their edits.
  • If a TTA member changes the Review State to Closed, the Review Type is always forced to None and further edits are prevented.
  • A TTA member is prevented from changing the Review Type to None if the Review State is Finalized.

If in Consensus, an ISR cannot be modified. A TTA member should be able to modify the Review Type. If they need to change a Primary, Secondary, or Tertiary to None this should only be done via changing the Review State to Closed.

Open Actions: